According to the "Source code organization" section in Developer notes, using namespace should be avoided. This commit removes using namespace std from bitcoin-cli/-tx and adds the std:: prefix in appropriate places.
Refactor: Stop using namespace std (bitcoin-cli/-tx). #9220
pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:no-using-ns changing 2 files +108 −112-
kallewoof commented at 8:26 AM on November 25, 2016: member
-
Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. 2f2625a0bb
-
laanwj commented at 8:28 AM on November 25, 2016: member
Yes, this has to be done at some point.
-
sipa commented at 8:28 AM on November 25, 2016: member
Concept ACK
- fanquake added the label Refactoring on Nov 25, 2016
-
paveljanik commented at 8:35 AM on November 25, 2016: contributor
ACK https://github.com/bitcoin/bitcoin/pull/9220/commits/2f2625a0bb94db220a6f5560fa942159b66ac61e
Good candidate for same-binary check.
-
MarcoFalke commented at 10:25 AM on November 25, 2016: member
same-binaries ACK 2f2625a0bb94db220a6f5560fa942159b66ac61e
-
jonasschnelli commented at 10:29 AM on November 25, 2016: contributor
utACK 2f2625a0bb94db220a6f5560fa942159b66ac61e
- MarcoFalke merged this on Nov 25, 2016
- MarcoFalke closed this on Nov 25, 2016
- MarcoFalke referenced this in commit e22f409f18 on Nov 25, 2016
-
kallewoof commented at 7:38 AM on November 28, 2016: member
@MarcoFalke I can't find any resources on same-binaries checking. I would like to make a more encompassing commit that deals with all these, but the diff is rather big so I'd like to do the same-binaries check beforehand myself.
-
fanquake commented at 7:43 AM on November 28, 2016: member
@kallewoof Have a look at this repo https://github.com/laanwj/bitcoin-maintainer-tools
-
kallewoof commented at 7:45 AM on November 28, 2016: member
Ahh, thanks a lot!
- kallewoof deleted the branch on Dec 1, 2016
- codablock referenced this in commit eef4b72182 on Jan 16, 2018
- codablock referenced this in commit 36b0620e3e on Jan 16, 2018
- codablock referenced this in commit c87c151426 on Jan 17, 2018
- zkbot referenced this in commit 3b0a5bcd24 on Apr 13, 2018
- zkbot referenced this in commit 65a8f9f201 on Apr 13, 2018
- andvgal referenced this in commit ce08af0c77 on Jan 6, 2019
- CryptoCentric referenced this in commit 92a8b0eb5b on Feb 25, 2019
- MarcoFalke locked this on Sep 8, 2021
Labels