Add some notes about the workflow for changes to code that exists in subtrees.
Developer docs about existing subtrees. #9246
pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:devdocs_for_subtrees changing 1 files +31 −0-
gmaxwell commented at 8:46 AM on November 30, 2016: contributor
- fanquake added the label Docs and Output on Nov 30, 2016
-
laanwj commented at 9:07 AM on November 30, 2016: member
ACK
-
in doc/developer-notes.md:None in 1c8a82d862 outdated
425 | + 426 | +- src/leveldb 427 | + - Upstream at https://github.com/google/leveldb ; Maintained by Google, but open important PRs to Core to avoid delay 428 | + 429 | +- src/libsecp256k1 430 | + - Upstream at https://github.com/bitcoin-core/secp256k1/ ; actively maintaned by Core contributors.
paveljanik commented at 9:17 AM on November 30, 2016:maintaned -> maintained
in doc/developer-notes.md:None in 1c8a82d862 outdated
407 | @@ -408,6 +408,34 @@ GUI 408 | should not interact with the user. That's where View classes come in. The converse also 409 | holds: try to not directly access core data structures from Views. 410 | 411 | +Subtrees 412 | +---------- 413 | + 414 | +Several parts of the repository are subtrees of software maintained elsewhere. 415 | + 416 | + Some of these are maintained by active developers of Bitcoin Core, in which case changes should probably go
paveljanik commented at 9:18 AM on November 30, 2016:Why SPC at the beginning? To mark paragraph?
Two spaces?
paveljanik commented at 9:35 AM on November 30, 2016: contributorConcept ACK. This is needed.
Travis failure in
sendheaders.pyunrelated but strange 8)in doc/developer-notes.md:None in 1c8a82d862 outdated
419 | + 420 | + Others are external projects without a tight relationship with our project. Changes to these should also 421 | +be sent upstream but bugfixes may also be prudent to PR against Bitcoin Core so that they can be integrated 422 | +quickly. Cosmetic changes should be purely taken upstream. 423 | + 424 | +Current subtrees include:
MarcoFalke commented at 10:52 AM on November 30, 2016:Maybe link to https://github.com/bitcoin/bitcoin/tree/master/contrib/devtools#git-subtree-checksh, so we don't have to keep track to update 2 places whenever something changes?
MarcoFalke commented at 10:52 AM on November 30, 2016: memberConcept ACK
fanquake commented at 12:16 AM on December 1, 2016: memberACK, post nits addressed.
jonasschnelli commented at 7:56 AM on December 1, 2016: contributorNice. ACK. Agree with @MarcoFalke to add a link to https://github.com/bitcoin/bitcoin/tree/master/contrib/devtools#git-subtree-checksh somewhere.
08ed8c1d07Developer docs about existing subtrees.
Add some notes about the workflow for changes to code that exists in subtrees.
gmaxwell commented at 2:34 PM on December 2, 2016: contributorUpdated for nits.
MarcoFalke merged this on Dec 2, 2016MarcoFalke closed this on Dec 2, 2016MarcoFalke referenced this in commit 98514988a3 on Dec 2, 2016codablock referenced this in commit 25db4596b9 on Jan 16, 2018codablock referenced this in commit fdb8b6ddbf on Jan 16, 2018codablock referenced this in commit b390e8ee57 on Jan 17, 2018andvgal referenced this in commit f3a25be242 on Jan 6, 2019CryptoCentric referenced this in commit 33cf4433a4 on Feb 25, 2019MarcoFalke locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me