[depends] ZeroMQ 4.2.2 #9254

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:zeromq-4-2-0 changing 5 files +38 −53
  1. fanquake commented at 4:52 am on December 1, 2016: member

    Update depends ZeroMQ to 4.2.2, the release notes are available here.

    We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn’t yet made it into a release).

    --without-documentation is deprecated and has been replaced with --without-docs. --disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac. Updated dependencies.md. --disable-curve-keygen disable building the curve key generation tool. See here.

    Can someone on windows test that this is still working correctly. Maybe @achow101 ?

  2. fanquake added the label Build system on Dec 1, 2016
  3. fanquake assigned theuni on Dec 1, 2016
  4. jonasschnelli commented at 7:53 am on December 1, 2016: contributor
    Travis Windows (depends build) is failing. I think you need to adopt the MinGW static patches instead of removing.
  5. fanquake commented at 3:04 am on December 2, 2016: member

    The patches were only turning this line: AC_MSG_ERROR([Building static libraries is not supported under MinGW32]) into CPPFLAGS="-DZMQ_STATIC $CPPFLAGS" (in two steps, as we wanted to use the commits from upstream). The new configure.ac now contains both patches, see here, so I think this is a different issue. Will investigate shortly.

     0/usr/share/mingw-w64/include/netioapi.h:458:3: error: ‘SOCKADDR_INET’ has not been declared
 1   SOCKADDR_INET *BestSourceAddress
 2   ^
 3In file included from /usr/share/mingw-w64/include/iphlpapi.h:16:0,
 4                 from src/windows.hpp:58,
 5                 from src/precompiled.hpp:37,
 6                 from src/address.cpp:30:
 7/usr/share/mingw-w64/include/netioapi.h:585:9: error: ‘SOCKADDR_INET’ does not name a type
 8   const SOCKADDR_INET *SourceAddress
 9         ^
10In file included from src/windows.hpp:58:0,
11                 from src/precompiled.hpp:37,
12                 from src/address.cpp:30:
13/usr/share/mingw-w64/include/iphlpapi.h:147:5: error: ‘SOCKADDR_IN6’ does not name a type
14     SOCKADDR_IN6 Ipv6Address;
15     ^
  6. fanquake force-pushed on Jan 4, 2017
  7. fanquake commented at 12:51 pm on January 4, 2017: member
    Pushed a commit to update to the latest point release (4.2.1), may also help with these issues.
  8. fanquake renamed this:
    [depends] ZeroMQ 4.2.0
    [depends] ZeroMQ 4.2.1
    on Jan 4, 2017
  9. laanwj commented at 10:42 am on January 5, 2017: member
    Still the SOCKADDR_INET issue on win32/64
  10. fanquake force-pushed on Jan 16, 2017
  11. fanquake force-pushed on Feb 19, 2017
  12. fanquake renamed this:
    [depends] ZeroMQ 4.2.1
    [depends] ZeroMQ 4.2.2
    on Feb 19, 2017
  13. fanquake force-pushed on Mar 30, 2017
  14. laanwj commented at 10:20 am on April 3, 2017: member
    Seems this is blocked by an upstream issue?
  15. laanwj added the label Upstream on Apr 3, 2017
  16. fanquake force-pushed on Apr 27, 2017
  17. fanquake force-pushed on Apr 27, 2017
  18. fanquake force-pushed on Apr 27, 2017
  19. fanquake force-pushed on May 13, 2017
  20. fanquake force-pushed on May 13, 2017
  21. fanquake force-pushed on May 13, 2017
  22. laanwj added this to the milestone 0.16.0 on Aug 23, 2017
  23. fanquake force-pushed on Sep 10, 2017
  24. fanquake force-pushed on Sep 10, 2017
  25. fanquake force-pushed on Sep 10, 2017
  26. fanquake force-pushed on Sep 10, 2017
  27. fanquake force-pushed on Sep 10, 2017
  28. TheBlueMatt commented at 0:17 am on September 29, 2017: member
    Has the issue been reported upstream? Any closer to resolving this one?
  29. fanquake commented at 2:37 am on October 6, 2017: member
    @theuni Can you take a look here you have a chance? We discussed setting WINNT a while back.
  30. fanquake requested review from theuni on Oct 6, 2017
  31. fanquake force-pushed on Oct 12, 2017
  32. MarcoFalke removed this from the milestone 0.16.0 on Nov 22, 2017
  33. MarcoFalke added this to the milestone 0.17.0 on Nov 22, 2017
  34. MarcoFalke commented at 6:59 pm on November 22, 2017: member
    @fanquake Moved this to 0.17.0, since it seems stuck.
  35. theuni commented at 1:54 am on November 29, 2017: member

    Sorry for overlooking this.

    I believe I’ve managed to track down the issue. @fanquake Could you try replacing your second commit with this one instead: https://github.com/theuni/bitcoin/commit/ef3ced4e0d0519c903bf115760aa3307f60a09ad ?

    That should work around the missing includes.

  36. fanquake force-pushed on Nov 29, 2017
  37. fanquake force-pushed on Nov 29, 2017
  38. fanquake force-pushed on Nov 29, 2017
  39. fanquake commented at 2:41 am on November 29, 2017: member
    @theuni Thanks. Just had to trim the patch whitespace to keep the linter happy. Tests looks good now. Re-assigning to the 0.16.0 milestone.
  40. fanquake removed this from the milestone 0.17.0 on Nov 29, 2017
  41. fanquake added this to the milestone 0.16.0 on Nov 29, 2017
  42. fanquake force-pushed on Nov 29, 2017
  43. theuni approved
  44. theuni commented at 6:08 am on November 29, 2017: member
    utACK 4fd7af8ec3eaebbebd1b431a6de668eeabdd8d54
  45. [depends] ZeroMQ 4.2.2 387879dd4c
  46. depends: fix zmq build with mingw < 4.0 126999d1cc
  47. fanquake force-pushed on Nov 29, 2017
  48. fanquake commented at 11:35 am on November 29, 2017: member
    Added --disable-curve-keygen to our configure options. This option disables building the curve key generation tool, see the zeromq configure.ac.
  49. theuni commented at 5:25 pm on November 29, 2017: member
    Sure, utACK 126999d1cc1b2513cb2ca62a70db0cd6a912a7ba.
  50. laanwj merged this on Nov 30, 2017
  51. laanwj closed this on Nov 30, 2017
  52. laanwj referenced this in commit 6d3dc52b6b on Nov 30, 2017
  53. laanwj referenced this in commit 180a25596a on Dec 22, 2017
  54. laanwj referenced this in commit 765a3ebb02 on Mar 6, 2018
  55. fanquake deleted the branch on Dec 16, 2019
  56. PastaPastaPasta referenced this in commit 40031ae594 on Mar 14, 2020
  57. PastaPastaPasta referenced this in commit ce0118b613 on Mar 14, 2020
  58. deadalnix referenced this in commit 179fdb728a on Mar 27, 2020
  59. PastaPastaPasta referenced this in commit 1ea89b0285 on Mar 27, 2020
  60. PastaPastaPasta referenced this in commit 4a832e8345 on Mar 28, 2020
  61. PastaPastaPasta referenced this in commit 00de0f94d5 on Mar 29, 2020
  62. PastaPastaPasta referenced this in commit 652bb16d21 on Mar 31, 2020
  63. UdjinM6 referenced this in commit a6b3d7d2a6 on Mar 31, 2020
  64. PastaPastaPasta referenced this in commit 7b1f32082c on Apr 1, 2020
  65. 10xcryptodev referenced this in commit 8cc575cced on May 16, 2020
  66. 10xcryptodev referenced this in commit 45db031556 on May 17, 2020
  67. zkbot referenced this in commit e3d5ddbef4 on Oct 8, 2020
  68. zkbot referenced this in commit 6e4090d840 on Oct 8, 2020
  69. ckti referenced this in commit 4e88546e3d on Mar 28, 2021
  70. ckti referenced this in commit 1ece1b4028 on Mar 28, 2021
  71. gades referenced this in commit 6db1fa619c on Jun 24, 2021
  72. CryptoCentric referenced this in commit dc6ddfc2e0 on Jul 2, 2021
  73. CryptoCentric referenced this in commit 7732baefae on Jul 2, 2021
  74. CryptoCentric referenced this in commit 430e0c7120 on Jul 2, 2021
  75. ftrader referenced this in commit 44d102f75f on Aug 13, 2021
  76. MarcoFalke locked this on Dec 16, 2021


fanquake jonasschnelli laanwj TheBlueMatt MarcoFalke theuni

Labels
Build system Upstream

Milestone
0.16.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 19:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me