Fix Win32 RPC Crashes. #938

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:guirpcwin32 changing 2 files +3 −2

TheBlueMatt commented at 2:26 AM on March 15, 2012: member

This resolves #820 and #640.
TheBlueMatt commented at 4:41 AM on March 15, 2012: member

~~Nevermind, Ive solved the problem.~~ Well, OK maybe not quite, but I am getting closer.
TheBlueMatt closed this on Mar 15, 2012
TheBlueMatt reopened this on Mar 15, 2012
laanwj commented at 9:59 AM on March 15, 2012: member

If we're going to disable it, please add an error message, don't ignore the flag silently.
TheBlueMatt commented at 3:02 PM on March 15, 2012: member

Done.
Fix Win32 RPC Crashes. 8864019f6d

in src/init.cpp:None in 4ec7371e43 outdated

 263 | @@ -264,7 +264,14 @@ bool AppInit2(int argc, char* argv[])
 264 |      if (fDaemon)
 265 |          fServer = true;
 266 |      else
 267 | +    {
 268 | +#if !defined(WIN32) || !defined(QT_GUI)
 269 |          fServer = GetBoolArg("-server");
 270 | +#else
 271 | +        wxMessageBox(_("Error: cannot run an RPC server in GUI mode, ignoring -server."), "Bitcoin");

gavinandresen commented at 4:19 PM on March 15, 2012:

This logic doesn't look right to me-- won't the message box pop up always with this change?

Should be something like:

fServer = GetBoolArg("-server");
#if defined(WIN32) && defined(QT_GUI)
... messageBox(ignoring....)
fServer = false;
#endif

TheBlueMatt commented at 4:34 PM on March 15, 2012:

if defined(WIN32) && defined(QT_GUI) is equivalent to if !(!defined(WIN32) || !defined(QT_GUI)) tough maybe a bit uglier...

TheBlueMatt commented at 6:32 PM on March 16, 2012: member

Changed to fix the problem itself.
gmaxwell commented at 6:32 PM on March 16, 2012: contributor

ACK.
gmaxwell referenced this in commit fa689db37b on Mar 16, 2012
gmaxwell merged this on Mar 16, 2012
gmaxwell closed this on Mar 16, 2012
coblee referenced this in commit 153398b5c2 on Jul 17, 2012
suprnurd referenced this in commit ee266f2d01 on Dec 5, 2017
ptschip referenced this in commit 514d59f0e9 on Jan 25, 2018
lateminer referenced this in commit 0ac0116ae4 on Oct 30, 2019
KolbyML referenced this in commit 565e630f64 on Sep 4, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#640 Intermittant crash in bitcoin-qt.exe 0.5.0 rc5 when using RPC commands #820 bitcoin-qt 0.5.2 crash after extended run with p2pool