Don’t ask for TX relay from feeler connections #9403

1. 
   rebroad commented at 4:09 pm on December 21, 2016: contributor

   Although feeler connections are fairly brief (although not as brief as they used to be), we are not interested in receiving transactions from these connections therefore set relay to false when sending the version message.
2. Don't ask for TX relay from feeler connections 99e51ea7b1
3. 
   gmaxwell commented at 4:18 pm on December 21, 2016: contributor

   Concept ACK on the relay suppression but I don’t see a reason to reformat the sendmessage log entry.
4. fanquake added the label P2P on Dec 21, 2016
5. 
   rebroad commented at 12:49 pm on December 23, 2016: contributor

   @gmaxwell it wasn’t just a reformat, but now includes an indication whether relay is set true or false.
6. 
   gmaxwell commented at 6:18 pm on December 23, 2016: contributor

   I know, but the change can be made without reformatting it, other than adding the field or without reformatting it at all. When you reformat log entries it breaks parsing tools, which encourages serious operations to delay their upgrades. We should be a little more conservative in breaking log entries.

   Getpeerinfo already shows the state.

7. 
   rebroad commented at 1:57 pm on December 25, 2016: contributor

   @gmaxwell the change is “made without reformatting it, other than adding the field” - not sure what other reformatting you are referring to. I’ve looked at the code there times now and cannot see any reformatting, other than adding the field.
8. 
   fanquake commented at 10:00 am on April 2, 2017: member

   Needs a rebase.
9. 
   fanquake commented at 8:45 am on May 17, 2017: member

   Closing as no follow up. Please rebase & re-open when ready.
10. fanquake closed this on May 17, 2017

    ---

11. DrahtBot locked this on Sep 8, 2021

Contributors
rebroad gmaxwell fanquake

Labels
P2P