Update the Windows build notes #9433

pull droark wants to merge 1 commits into bitcoin:master from droark:docs changing 1 files +10 −7

droark commented at 12:01 AM on December 27, 2016: contributor
- Clarify the Windows Subsystem For Linux section.
- Clarify the build requirements.
fanquake added the label Docs and Output on Dec 27, 2016
fanquake added the label Windows on Dec 27, 2016
fanquake commented at 12:13 AM on December 27, 2016: member

Looks ok. utACK 1f30bc3
in doc/build-windows.md:None in 1f30bc3340 outdated
```
  71 | @@ -68,7 +72,7 @@ Then build using:
  72 |      cd ..
  73 |      ./autogen.sh # not required when building from tarball
  74 |      CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure --prefix=/
  75 | -    make
  76 | +    make -j4
```
jonasschnelli commented at 8:21 AM on December 27, 2016:

nit: not sure if we should set the jobs amount in the documentation. IMO we also don't do that for other build docs. It depends on available RAM/cores.

sipa commented at 4:46 PM on December 27, 2016:

If you're going to add -j in places, at least explain that it impacts parallellism in a comment.
droark force-pushed on Dec 27, 2016
droark commented at 5:35 PM on December 27, 2016: contributor

Removed the -j flags (my own and the ones that were present) and did a fixup/reword. @jonasschnelli and @sipa brought up good points regarding parallelism. Doing a parallel make on the depends portion caused several errors on my system. I was able to keep trying and get it to work but it wasn't ideal.
droark force-pushed on Dec 29, 2016

Update the Windows build notes

- Clarify the Windows Subsystem For Linux section.
- Clarify the build requirements.

b705a04b91

droark force-pushed on Dec 30, 2016
droark commented at 5:19 AM on January 1, 2017: contributor

Also, just to clarify, I did successfully build and run the 32-bit version. make check passed too.
MarcoFalke commented at 11:55 AM on January 1, 2017: member

ACK b705a04
MarcoFalke merged this on Jan 1, 2017
MarcoFalke closed this on Jan 1, 2017
MarcoFalke referenced this in commit caa2f106d7 on Jan 1, 2017
codablock referenced this in commit b584f56304 on Jan 18, 2018
andvgal referenced this in commit cfd44d09f7 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels