[Qt] Show more significant warning if we fall back to the default fee #9481

pull jonasschnelli wants to merge 3 commits into bitcoin:master from jonasschnelli:2017/01/fee_warning changing 2 files +29 −0

jonasschnelli commented at 10:02 AM on January 6, 2017: contributor

There are multiple reports (bitcoin.stackoverflow, etc.) from users sending (very-)low-fee-transactions with bitcoin-core. The reason for this is probably that some users are not waiting long enough until smartfee estimation is possible. The current fallback fee is 0.0002BTC/kb, one of my ~0.13.0 nodes is telling me 0.00069534 for a confirmation target of 25 blocks. Using the current fallback fee can be troublesome.

If we have to use the fallback-ferrate, we should probably warn the user more significant (there is no "warning" right now.).

Screenshots: <img width="1056" alt="bildschirmfoto 2017-01-06 um 11 00 07" src="https://cloud.githubusercontent.com/assets/178464/21714484/7b16f4a4-d3ff-11e6-90f1-2f7aaf86673a.png"> <img width="1056" alt="bildschirmfoto 2017-01-06 um 11 00 09" src="https://cloud.githubusercontent.com/assets/178464/21714485/7b394a90-d3ff-11e6-9c3c-1a28a5f591f1.png"> <img width="208" alt="bildschirmfoto 2017-01-06 um 11 02 18" src="https://cloud.githubusercontent.com/assets/178464/21714503/9ca054da-d3ff-11e6-87c9-304ac1d5b1b7.png">
[Qt] Show more significant warning if we fall back to the default fee c5adf8f267
jonasschnelli added the label GUI on Jan 6, 2017
in src/qt/forms/sendcoinsdialog.ui:None in c5adf8f267 outdated
```
 759 | @@ -760,10 +760,30 @@
 760 |             </layout>
 761 |            </item>
 762 |            <item>
 763 | +           <widget class="QLabel" name="fallbackFeeWarningLabel">
 764 | +            <property name="toolTip">
 765 | +             <string>Using the fallbackfee can result in sending a transaction that will take serval hours or days (or never) to confirm. Consider choosing your fee manually or wait until your have validated the complete chain.</string>
```
MarcoFalke commented at 10:50 AM on January 6, 2017:

validating the whole chain is not enough. You also need the mempool at all times of validation.

MarcoFalke commented at 10:50 AM on January 6, 2017:

The warning is one sided. Using the fallbackfee might also overpay

MarcoFalke commented at 10:51 AM on January 6, 2017:

Maybe just mention that the fallbackfee is hardcoded and the fee should be selected manually. (or the node should be run for some hours to initialize smart fee)

paveljanik commented at 11:05 AM on January 6, 2017:

serval -> several

jonasschnelli commented at 12:05 PM on January 6, 2017:

I have though about that, but to not over-explain this, I was picking out the most important part, which is probably a validated chain. And since we persist the mempool, this is less of a problem.
MarcoFalke commented at 10:52 AM on January 6, 2017: member

Concept ACK
jonasschnelli force-pushed on Jan 6, 2017
jonasschnelli commented at 12:07 PM on January 6, 2017: contributor

Fixed the text after recommendation from @paveljanik and @MarcoFalke. Happy to exchange the text(s) (tooltip / label) with better ones if someone has intentions to provide better ones.
morcos commented at 2:04 PM on January 6, 2017: member
Concept ACK

I think there are a few other things we could potentially do:
- Clarify via release notes that fallbackfee can be set on the command line and should be when starting a new node or catching up from a long time ago.
- Change the default fallbackfee every release (yeah i know... no one likes this, including me)
- Prevent transactions from going out using fee estimation if we would fall back to the fallbackfee (unless it was explicitly set by the user?)
It's always going to be problem to get transactions out the door before we've had a chance to bootstrap fee estimation but would be nice to make it harder for users to shoot themselves in the foot. At least now the fallbackfee is such that their transactions will probably be confirmed within a day or two, but that might not remain true...

In any case, warning with the current behavior is a good first step.
gmaxwell commented at 12:44 AM on January 7, 2017: contributor

@morcos to your list: get bumpfee working really well and worry less about this. :)

in src/qt/forms/sendcoinsdialog.ui:None in 404a9c5f42 outdated

 759 | @@ -760,10 +760,30 @@
 760 |             </layout>
 761 |            </item>
 762 |            <item>
 763 | +           <widget class="QLabel" name="fallbackFeeWarningLabel">
 764 | +            <property name="toolTip">
 765 | +             <string>Using the static fallback-fee can result in sending a transaction that will take several hours or days (or never) to confirm or that you overpay the fees. Consider choosing your fee manually or wait until your have validated the complete chain.</string>
 766 | +            </property>
 767 | +            <property name="styleSheet">
 768 | +             <string notr="true">color: rgb(255, 150, 0);

luke-jr commented at 10:14 AM on February 9, 2017:

This affects the tooltip style as well. Additionally, it is hard to read on some styles.

laanwj commented at 10:19 AM on February 9, 2017: member

This is an excellent idea, thanks for implementing it. Concept ACK!
luke-jr commented at 6:36 AM on February 17, 2017: member

Actually, this seems redundant with labelSmartFee2...? Maybe that should just be made clearer (disable the slider??)

Edit: (Oh, nevermind. That's not visible by default.)
luke-jr commented at 8:43 AM on February 17, 2017: member

https://github.com/jonasschnelli/bitcoin/compare/2017/01/fee_warning...luke-jr:fee_warning
Qt/Send: Figure a decent warning colour from theme 3e4d7bfcb7
Qt/Send: Give fallback fee a reasonable indent 7abe7bbf61
jonasschnelli commented at 10:43 AM on February 17, 2017: contributor

Added @luke-jr commits (@thanks!). Looks good on Windows. Maybe we can get a windows and linux dark scheme screenshot?

<img width="1028" alt="bildschirmfoto 2017-02-17 um 11 43 00" src="https://cloud.githubusercontent.com/assets/178464/23062489/41186440-f506-11e6-9e50-56dea2cad002.png">
jonasschnelli force-pushed on Feb 17, 2017
laanwj commented at 12:06 PM on March 14, 2017: member

Worksforme. ACK 7abe7bb:
laanwj merged this on Mar 14, 2017
laanwj closed this on Mar 14, 2017
laanwj referenced this in commit ce01e6226c on Mar 14, 2017
practicalswift commented at 8:09 AM on March 16, 2017: contributor

I found a typo in this PR - see #10008 for details.

Sorry for not catching it pre-merge :-)
luke-jr referenced this in commit 8697d3ceb3 on Jun 5, 2017
luke-jr referenced this in commit a8e5cf49bd on Jun 5, 2017
luke-jr referenced this in commit aca4b6dbcb on Jun 5, 2017
codablock referenced this in commit 539cf5c178 on Jan 26, 2018
andvgal referenced this in commit 2c7bcc1e03 on Jan 6, 2019
CryptoCentric referenced this in commit 0e3e77040f on Feb 27, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10008 [trivial] Fix a typo (introduced two days ago) in the default fee warning