Clarify assumptions made about when BlockCheck is called #9558

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-01-blockcheckeddocs changing 1 files +6 −1
  1. TheBlueMatt commented at 9:42 PM on January 14, 2017: member

    Based on #9400, this clarifies the docs above BlockChecked (documenting the assumption #9400 makes).

  2. Clarify assumptions made about when BlockCheck is called c4a6929a3d
  3. fanquake added the label P2P on Jan 15, 2017
  4. jnewbery commented at 8:01 PM on January 20, 2017: member

    ACK

  5. morcos commented at 8:34 PM on January 20, 2017: member

    ACK

  6. sdaftuar commented at 7:30 PM on February 23, 2017: member

    nit: It's slightly surprising to me that we call BlockChecked() before calling UpdateTip() (reading the comment here, I would have guessed that UpdateTip() would already have been called).

    ACK anyway, this is a clear improvement.

  7. kallewoof approved
  8. kallewoof commented at 12:19 AM on March 1, 2017: member

    ACK c4a6929

  9. fanquake commented at 11:15 PM on March 22, 2017: member

    ACK c4a6929

  10. jonasschnelli commented at 7:18 AM on March 23, 2017: contributor

    ACK c4a6929a3dd729abe9e55cba6417c21efa3ffc48

  11. jonasschnelli merged this on Mar 23, 2017
  12. jonasschnelli closed this on Mar 23, 2017

  13. jonasschnelli referenced this in commit 7b585cf70e on Mar 23, 2017
  14. PastaPastaPasta referenced this in commit b1b3a0c0e6 on Mar 14, 2019
  15. PastaPastaPasta referenced this in commit 1afad7f096 on May 20, 2019
  16. PastaPastaPasta referenced this in commit 07e0567dcc on May 21, 2019
  17. PastaPastaPasta referenced this in commit 057a8e75a1 on May 21, 2019
  18. barrystyle referenced this in commit 91338b12bd on Jan 22, 2020
  19. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me