Based on #9400, this clarifies the docs above BlockChecked (documenting the assumption #9400 makes).
Clarify assumptions made about when BlockCheck is called #9558
pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-01-blockcheckeddocs changing 1 files +6 −1-
TheBlueMatt commented at 9:42 PM on January 14, 2017: member
-
Clarify assumptions made about when BlockCheck is called c4a6929a3d
- fanquake added the label P2P on Jan 15, 2017
-
instagibbs commented at 6:20 PM on January 19, 2017: member
-
jnewbery commented at 8:01 PM on January 20, 2017: member
ACK
-
morcos commented at 8:34 PM on January 20, 2017: member
ACK
-
sdaftuar commented at 7:30 PM on February 23, 2017: member
nit: It's slightly surprising to me that we call BlockChecked() before calling UpdateTip() (reading the comment here, I would have guessed that UpdateTip() would already have been called).
ACK anyway, this is a clear improvement.
- kallewoof approved
-
kallewoof commented at 12:19 AM on March 1, 2017: member
ACK c4a6929
-
fanquake commented at 11:15 PM on March 22, 2017: member
ACK c4a6929
-
jonasschnelli commented at 7:18 AM on March 23, 2017: contributor
ACK c4a6929a3dd729abe9e55cba6417c21efa3ffc48
- jonasschnelli merged this on Mar 23, 2017
- jonasschnelli closed this on Mar 23, 2017
- jonasschnelli referenced this in commit 7b585cf70e on Mar 23, 2017
- PastaPastaPasta referenced this in commit b1b3a0c0e6 on Mar 14, 2019
- PastaPastaPasta referenced this in commit 1afad7f096 on May 20, 2019
- PastaPastaPasta referenced this in commit 07e0567dcc on May 21, 2019
- PastaPastaPasta referenced this in commit 057a8e75a1 on May 21, 2019
- barrystyle referenced this in commit 91338b12bd on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021