Move wallet callbacks into cs_main (this effectively reverts #7946) #9583
pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:2017-01-revert-7946 changing 1 files +8 −9-
TheBlueMatt commented at 4:06 pm on January 19, 2017: member
-
TheBlueMatt force-pushed on Jan 19, 2017
-
in src/validation.cpp: in f73bd2c370 outdated
2472@@ -2473,20 +2473,20 @@ bool ActivateBestChain(CValidationState &state, const CChainParams& chainparams, 2473 pindexNewTip = chainActive.Tip(); 2474 pindexFork = chainActive.FindFork(pindexOldTip); 2475 fInitialDownload = IsInitialBlockDownload(); 2476+ 2477+ // throw all transactions though the signal-interface 2478+ // while _not_ holding the cs_main lock
sipa commented at 4:24 pm on January 19, 2017:This comments seems outdated now.
TheBlueMatt commented at 4:31 pm on January 19, 2017:Fixed -
Move wallet callbacks into cs_main (this effectively reverts #7946) 989989354b
-
in src/validation.cpp: in f73bd2c370 outdated
2480+ assert(pair.second); 2481+ const CBlock& block = *(pair.second); 2482+ for (unsigned int i = 0; i < block.vtx.size(); i++) 2483+ GetMainSignals().SyncTransaction(*block.vtx[i], pair.first, i); 2484+ } 2485 }
sipa commented at 4:26 pm on January 19, 2017:I think you need to clear connectTrace.blocksConnected here.
TheBlueMatt commented at 4:30 pm on January 19, 2017:It will be automatically when it continues the loop.
sipa commented at 11:35 pm on January 20, 2017:Oh, loop-scoped variable, never mind. -
TheBlueMatt force-pushed on Jan 19, 2017
-
morcos commented at 6:07 pm on January 19, 2017: member
utACK
I know we think this is on the top of our minds for further improvement, but I think it would make sense to document at least in the comments and maybe also the commit message why this matter.
-
TheBlueMatt commented at 6:58 pm on January 19, 2017: member
-
jonasschnelli commented at 7:20 pm on January 19, 2017: contributorutACK 989989354b68d3954fe2742b96c53eeb2e8a7670. I think it make sense to apply this revert and go for a better solution in 0.15.
-
laanwj added this to the milestone 0.14.0 on Jan 19, 2017
-
laanwj commented at 7:25 pm on January 19, 2017: memberConcept ACK
-
jtimon commented at 8:08 pm on January 19, 2017: contributorConcept ACK
-
MarcoFalke commented at 8:22 pm on January 19, 2017: memberConcept ACK
-
gmaxwell commented at 8:27 pm on January 19, 2017: contributorConcept ACK.
-
TheBlueMatt referenced this in commit 4c1fe09b3f on Jan 20, 2017
-
TheBlueMatt referenced this in commit e97b94fc67 on Jan 20, 2017
-
TheBlueMatt referenced this in commit dbe3075fae on Jan 20, 2017
-
TheBlueMatt referenced this in commit 14dece1801 on Jan 20, 2017
-
TheBlueMatt referenced this in commit a8c28a1984 on Jan 20, 2017
-
TheBlueMatt referenced this in commit a07db1f0fb on Jan 20, 2017
-
sipa commented at 11:35 pm on January 20, 2017: memberutACK
-
TheBlueMatt referenced this in commit 7bf80cbeab on Jan 20, 2017
-
TheBlueMatt referenced this in commit b9c04b76a3 on Jan 20, 2017
-
TheBlueMatt referenced this in commit b802a5bb8c on Jan 20, 2017
-
TheBlueMatt referenced this in commit e5802a1864 on Jan 20, 2017
-
TheBlueMatt referenced this in commit 4977fec015 on Jan 20, 2017
-
TheBlueMatt referenced this in commit 402c3368f8 on Jan 20, 2017
-
TheBlueMatt referenced this in commit ce8029dacb on Jan 23, 2017
-
TheBlueMatt referenced this in commit dda1f3c78c on Jan 23, 2017
-
laanwj commented at 6:43 am on January 23, 2017: memberutACK 9899893
-
laanwj merged this on Jan 23, 2017
-
laanwj closed this on Jan 23, 2017
-
laanwj referenced this in commit eafba4e273 on Jan 23, 2017
-
TheBlueMatt referenced this in commit 80ac497c9a on Jan 23, 2017
-
TheBlueMatt referenced this in commit 997f1d8643 on Jan 25, 2017
-
TheBlueMatt referenced this in commit acd7b69d15 on Feb 8, 2017
-
TheBlueMatt referenced this in commit a61a6de7ce on Feb 8, 2017
-
TheBlueMatt referenced this in commit 1eb9e4cbb0 on Feb 8, 2017
-
TheBlueMatt referenced this in commit e1c2b46e1c on Feb 18, 2017
-
TheBlueMatt referenced this in commit 57ad383265 on Feb 18, 2017
-
TheBlueMatt referenced this in commit c5e8a0b92a on Mar 6, 2017
-
TheBlueMatt referenced this in commit 6266b75cc0 on Mar 7, 2017
-
TheBlueMatt referenced this in commit dcfd01cf1c on Mar 8, 2017
-
TheBlueMatt referenced this in commit 647bd58b95 on Apr 10, 2017
-
TheBlueMatt referenced this in commit 76856f237d on Apr 17, 2017
-
TheBlueMatt referenced this in commit ea402b2097 on Apr 26, 2017
-
TheBlueMatt referenced this in commit fac8c1f0ad on Apr 26, 2017
-
TheBlueMatt referenced this in commit a3e3a757e4 on Apr 26, 2017
-
TheBlueMatt referenced this in commit 31091c5cfb on Apr 26, 2017
-
TheBlueMatt referenced this in commit b6a3a6eecf on Apr 26, 2017
-
TheBlueMatt referenced this in commit ba1890ec30 on Apr 26, 2017
-
TheBlueMatt referenced this in commit 7da495a80a on Apr 26, 2017
-
TheBlueMatt referenced this in commit 7407d36589 on Apr 26, 2017
-
TheBlueMatt referenced this in commit 36b1a253d2 on Apr 27, 2017
-
TheBlueMatt referenced this in commit e0681b45f2 on Apr 27, 2017
-
TheBlueMatt referenced this in commit 4115319fe1 on Apr 27, 2017
-
TheBlueMatt referenced this in commit b7317f8b8e on May 3, 2017
-
TheBlueMatt referenced this in commit c2b16b9a30 on May 4, 2017
-
TheBlueMatt referenced this in commit 2f1a5e82b5 on May 5, 2017
-
TheBlueMatt referenced this in commit 48689173e9 on Jun 8, 2017
-
TheBlueMatt referenced this in commit 0a81eaeaa6 on Jun 8, 2017
-
TheBlueMatt referenced this in commit 699fb26fdd on Jun 8, 2017
-
TheBlueMatt referenced this in commit f17a525765 on Jun 9, 2017
-
TheBlueMatt referenced this in commit 1f3234a4e7 on Jun 9, 2017
-
TheBlueMatt referenced this in commit 5230dedad5 on Jun 21, 2017
-
TheBlueMatt referenced this in commit 547223bffd on Jun 21, 2017
-
TheBlueMatt referenced this in commit f10d4a3c58 on Jun 21, 2017
-
TheBlueMatt referenced this in commit 0c457ac81e on Jun 21, 2017
-
TheBlueMatt referenced this in commit 3879786467 on Jul 7, 2017
-
TheBlueMatt referenced this in commit 417066ed81 on Jul 7, 2017
-
TheBlueMatt referenced this in commit 62e416d714 on Jul 11, 2017
-
TheBlueMatt referenced this in commit 2b24e583d1 on Aug 14, 2017
-
TheBlueMatt referenced this in commit 2a41f6aed6 on Aug 17, 2017
-
TheBlueMatt referenced this in commit 4b6a0c9aad on Sep 12, 2017
-
jnewbery referenced this in commit e28cb7409e on Sep 13, 2017
-
TheBlueMatt referenced this in commit 63afb38340 on Oct 1, 2017
-
TheBlueMatt referenced this in commit 51ca6003ca on Oct 1, 2017
-
TheBlueMatt referenced this in commit e6e43a85c8 on Oct 13, 2017
-
TheBlueMatt referenced this in commit 2960f2f22a on Oct 13, 2017
-
TheBlueMatt referenced this in commit e545dedf72 on Oct 13, 2017
-
laanwj referenced this in commit 927a1d7d08 on Nov 15, 2017
-
codablock referenced this in commit 8420dd2073 on Jan 19, 2018
-
codablock referenced this in commit 5f211ce25f on Jan 20, 2018
-
codablock referenced this in commit 9ba8a31d03 on Jan 21, 2018
-
HashUnlimited referenced this in commit 50ade5feeb on Mar 13, 2018
-
andvgal referenced this in commit 56ce909b20 on Jan 6, 2019
-
CryptoCentric referenced this in commit 9ee01b7423 on Feb 27, 2019
-
PastaPastaPasta referenced this in commit 61758874b8 on Feb 13, 2020
-
PastaPastaPasta referenced this in commit 76ed385c03 on Feb 13, 2020
-
PastaPastaPasta referenced this in commit 3eb80fdcd5 on Feb 29, 2020
-
PastaPastaPasta referenced this in commit 803530c83d on Feb 29, 2020
-
furszy referenced this in commit a4738c5301 on Feb 10, 2021
-
furszy referenced this in commit aec5755671 on Feb 18, 2021
-
furszy referenced this in commit a0b8ac4ea9 on Feb 19, 2021
-
furszy referenced this in commit c7ab4901f1 on Feb 21, 2021
-
ckti referenced this in commit 38a9ad2b41 on Mar 28, 2021
-
gades referenced this in commit 1459aa5a72 on Jun 30, 2021
-
MarcoFalke locked this on Sep 8, 2021
TheBlueMatt
sipa
morcos
jonasschnelli
laanwj
jtimon
MarcoFalke
gmaxwell
Milestone
0.14.0