Send final alert message to older peers after connecting. #9594

1. 
   gmaxwell commented at 3:01 AM on January 20, 2017: contributor

   The old Bitcoin alert system has long since been retired. ( See also: https://bitcoin.org/en/alert/2016-11-01-alert-retirement )

   This change causes each node to send any old peers that it connects with a copy of the final alert.

2. 
   achow101 commented at 3:16 AM on January 20, 2017: member

   Is the alert broadcast yet?

3. fanquake added the label P2P on Jan 20, 2017
4. 
   achow101 commented at 3:49 AM on January 20, 2017: member

   ACK b9b91f4917a2fed737cfb9752d123d2ffdbebad3

   Needs a 0.14 label

5. Send final alert message to older peers after connecting.

   The old Bitcoin alert system has long since been retired.
   ( See also: https://bitcoin.org/en/alert/2016-11-01-alert-retirement )
   
   This change causes each node to send any old peers that
    it connects with a copy of the final alert.
   
   The alert it hardcode cancels all other alerts including
    other final alerts.

   8ff8d219c3
6. 
   gmaxwell commented at 7:36 AM on January 20, 2017: contributor

   I updated the alert here to be one that also cancels all other final alerts too. @achow101 Review again please? re: broadcast question unlike prior alerts nodes that get this one will not relay it as relayuntil is set to zero (which will prevent them from spamming it out continually to all their peers-- probably preferable in the long term).

7. fanquake added this to the milestone 0.14.0 on Jan 20, 2017
8. 
   rebroad commented at 10:01 AM on January 20, 2017: contributor

   What is the final alert?

9. 
   laanwj commented at 1:28 PM on January 20, 2017: member

   @rebroad https://bitcoin.org/en/alert/2016-11-01-alert-retirement

10. 
    luke-jr commented at 11:32 PM on January 20, 2017: member

    Can we not make it conditional on the network version, so old nodes we relay it to other old nodes? (Might need a bump to network version?)

11. 
    gmaxwell commented at 12:50 AM on January 21, 2017: contributor

    @luke-jr No, almost all the fields of the final alert are fixed specifically. I'm doubtful that there is a subgraph of nodes that is reachable only via outdated ones, but we can still send a separate final alert that does relay once... but it shouldn't be the one we hardcode here.

12. 
    btcdrak commented at 2:05 PM on January 21, 2017: contributor

    utACK b9b91f4

13. 
    laanwj commented at 12:21 PM on January 23, 2017: member

    Code review ACK 8ff8d21, you promised it would only be a three-line change and you delivered :)

14. 
    jtimon commented at 2:28 PM on January 23, 2017: contributor

    Concept ACK

15. 
    TheBlueMatt commented at 5:14 PM on January 23, 2017: member

    utACK 8ff8d219c3d9a0b6f604bb99ca4a27ad77cdb69b. I did go manually deserialize the alert and look at each selected parameter and verify its all reasonable.

16. 
    laanwj commented at 9:31 AM on January 26, 2017: member

    Thanks for sanity-checking, @TheBlueMatt.

17. laanwj merged this on Jan 26, 2017
18. laanwj closed this on Jan 26, 2017

    ---

19. laanwj referenced this in commit fd7021142a on Jan 26, 2017
20. DrahtBot locked this on Sep 8, 2021

Milestone
0.14.0