[Trivial] add comment about setting peer as HB peer. #9604

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:HBpeercomment changing 1 files +9 −1

jnewbery commented at 7:18 PM on January 20, 2017: member

This adds a comment to the new logic for setting HB peers based on block validation (and aligns the code below to reflect the comment). It's not obvious why we're checking mapBlocksInFlight. Add a comment to explain. @TheBlueMatt

in src/net_processing.cpp:None in 9fb63e00ac outdated

 869 | +    // Check that:
 870 | +    // 1. The block is valid
 871 | +    // 2. We're not in initial block download
 872 | +    // 3. This is currently the best block. We haven't updated the tip yet so we have no
 873 | +    //    way to check this directly here. Instead we just check that there are currently
 874 | +    //    no other blocks in flight.

TheBlueMatt commented at 7:28 PM on January 20, 2017:

Note that this also implies this is currently the best block we're aware of, not just the best block we have.

morcos commented at 7:34 PM on January 20, 2017: member

utACK
jnewbery force-pushed on Jan 20, 2017

[Trivial] add comment about setting peer as HB peer.

This adds a comment to the new logic for setting HB peers based
on block validation (and aligns the code below to reflect the comment).
It's not obvious why we're checking mapBlocksInFlight. Add a comment to
explain.

dd5b0114cf

jnewbery force-pushed on Jan 20, 2017
jnewbery commented at 8:07 PM on January 20, 2017: member

Updated comment to "This is currently the best block we're aware of"
fanquake added the label Docs and Output on Jan 20, 2017
fanquake added the label P2P on Jan 20, 2017
TheBlueMatt commented at 12:00 AM on January 21, 2017: member

ACK
gmaxwell commented at 12:48 AM on January 21, 2017: contributor

ACK.
paveljanik commented at 4:10 PM on January 23, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9604/commits/dd5b0114cf9021e8639e48c2a33f0aaf82aeb14e
laanwj merged this on Feb 7, 2017
laanwj closed this on Feb 7, 2017
laanwj referenced this in commit 729de15b63 on Feb 7, 2017
jnewbery deleted the branch on Feb 7, 2017
gladcow referenced this in commit a4b0c1213b on Mar 8, 2018
gladcow referenced this in commit dd23c1bd40 on Mar 13, 2018
gladcow referenced this in commit a80140a202 on Mar 14, 2018
gladcow referenced this in commit 94bdbf40af on Mar 15, 2018
gladcow referenced this in commit e2c5657443 on Mar 15, 2018
gladcow referenced this in commit a730fc1b13 on Mar 15, 2018
gladcow referenced this in commit 3227f7939f on Mar 15, 2018
gladcow referenced this in commit 72571c754c on Mar 24, 2018
gladcow referenced this in commit 519187cb15 on Apr 4, 2018
UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels