qa: Increase a sync_blocks timeout in pruning.py #9628

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:2017-01-longer-pruning-sync changing 1 files +1 −1

sdaftuar commented at 2:36 PM on January 25, 2017: member

The last test in pruning.py (added in #7871) starts with trying to sync a big chain from one node to a fresh one; this regularly takes more than the default 60 seconds on the machine I use to run all the tests, so I've bumped the timeout on that sync_blocks call to 300 seconds.
in qa/rpc-tests/pruning.py:None in 0f57807258 outdated
```
 313 | @@ -314,7 +314,7 @@ def wallet_test(self):
 314 |          print ("Syncing node 5 to test wallet")
 315 |          connect_nodes(self.nodes[0], 5)
 316 |          nds = [self.nodes[0], self.nodes[5]]
 317 | -        sync_blocks(nds)
 318 | +        sync_blocks(nds, timeout=300)
```
morcos commented at 3:13 PM on January 25, 2017:

Could you pass an increased wait here or maybe better yet make sync_blocks calculate a wait based on timeout unless it's explicitly passed. Otherwise the 1000 lines of the debug log that travis saves quickly fill up.

sdaftuar commented at 3:21 PM on January 25, 2017:

Forgot about that, thanks -- bumped the wait to 5 seconds. No objection to teaching sync_blocks to be smarter as well, but I'd like this merged asap to get the test suite working again.
sdaftuar force-pushed on Jan 25, 2017
qa: Increase a sync_blocks timeout in pruning.py 2f10f06196
ryanofsky approved
ryanofsky commented at 4:04 PM on January 25, 2017: member

utACK 2f10f06196ace64c549172f9ab081d28115228d5
fanquake added the label Tests on Jan 25, 2017
morcos commented at 6:03 PM on January 25, 2017: member

utACK
TheBlueMatt commented at 11:58 PM on January 25, 2017: member

utACK
MarcoFalke merged this on Jan 26, 2017
MarcoFalke closed this on Jan 26, 2017
MarcoFalke referenced this in commit f89502306d on Jan 26, 2017
MarcoFalke commented at 12:13 AM on January 26, 2017: member

utACK 2f10f06196ace64c549172f9ab081d28115228d5
codablock referenced this in commit 9eef2a481b on Jan 19, 2018
codablock referenced this in commit 83ae266834 on Jan 20, 2018
codablock referenced this in commit 5a84b27dc1 on Jan 21, 2018
andvgal referenced this in commit 8530554773 on Jan 6, 2019
CryptoCentric referenced this in commit 7971788cc1 on Feb 27, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7871 Manual block file pruning.