[refactor] Remove using namespace <xxx> from src/ #9644

This is the final PR of the #9235 sub-sets, including the remaining files in src/.

I don't know if this should go into 0.14 or not (it is binary-checked so it should not affect anything), but I figured I would wrap these up just in case.

Same-binaries check:

$ ../bitcoin-maintainer-tools/build-for-compare.py 9b4d2673b7757fd242b13c972c73897c92a90ce1 b7b48c8bbdf7a90861610b035d8b0a247ef78c45 --executables "src/bitcoind,src/bitcoin-cli,src/bitcoin-tx" --patches "stripbuildinfo.patch,stripbuildinfo-without-using-ns.patch"
[...]
make[1]: Leaving directory '/tmp/repo/src'
>>> [do_build] Copying object files...
>>> [do_build] Performing basic analysis pass...
>>> [do_build] Use these commands to compare results:
>>> [do_build] $ sha256sum /tmp/compare/*.stripped
>>> [do_build] $ git diff -W --word-diff /tmp/compare/9b4d2673b7757fd242b13c972c73897c92a90ce1 /tmp/compare/b7b48c8bbdf7a90861610b035d8b0a247ef78c45
$ sha256sum /tmp/compare/*.stripped
e949fef0c4e3c9fcd7927acfaca0737629caa82cc70218e483adbb1ecc9b8bfc  /tmp/compare/bitcoin-cli.9b4d2673b7757fd242b13c972c73897c92a90ce1.stripped
e949fef0c4e3c9fcd7927acfaca0737629caa82cc70218e483adbb1ecc9b8bfc  /tmp/compare/bitcoin-cli.b7b48c8bbdf7a90861610b035d8b0a247ef78c45.stripped
59345e230f87b0f4a9a4f24b17dce83f783f13fe18fdaa9f88573400e6f8730c  /tmp/compare/bitcoind.9b4d2673b7757fd242b13c972c73897c92a90ce1.stripped
59345e230f87b0f4a9a4f24b17dce83f783f13fe18fdaa9f88573400e6f8730c  /tmp/compare/bitcoind.b7b48c8bbdf7a90861610b035d8b0a247ef78c45.stripped
512ca5f056c02478c638bf48c056e8bb12d5a7ca924f972bf2f1f8a833e92bab  /tmp/compare/bitcoin-tx.9b4d2673b7757fd242b13c972c73897c92a90ce1.stripped
512ca5f056c02478c638bf48c056e8bb12d5a7ca924f972bf2f1f8a833e92bab  /tmp/compare/bitcoin-tx.b7b48c8bbdf7a90861610b035d8b0a247ef78c45.stripped
$ git diff -W --word-diff /tmp/compare/9b4d2673b7757fd242b13c972c73897c92a90ce1 /tmp/compare/b7b48c8bbdf7a90861610b035d8b0a247ef78c45
$ 

The affected files and namespaces:

bloom.cpp:                std
chain.cpp:                std [unused]
core_read.cpp:            std
core_write.cpp:           std
init.cpp:                 std, boost::filesystem [inside void CleanupBlockRevFiles()]
merkleblock.cpp:          std
miner.cpp:                std
net_processing.cpp:       std
rest.cpp:                 std
timedata.cpp:             std
txdb.cpp:                 std
txmempool.cpp:            std
validation.cpp:           std

That's a much larger diff than I expected, but it seems sane, utACK.

Concept ACK, and if it doesn't change the binaries (I haven't checked myself yet), I'm fine with merging it anytime.

utACK. Thanks for doing this. See my related PR #9544.

utACK On Sat, 28 Jan 2017 at 07:16, practicalswift notifications@github.com wrote:

utACK. Thanks for doing this. See my related PR #9544 https://github.com/bitcoin/bitcoin/pull/9544.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9644#issuecomment-275832501, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0t8rorVIjg41JvY87Cun5egIxX5rABks5rWutOgaJpZM4LvjgS .

utACK

same binaries ACK on b7b48c8bbdf7a90861610b035d8b0a247ef78c45, but unfortunately we can not merge it, as it conflicts with an open net bug fix tagged for 0.14.

Meh, just going to merge this as the bugfix needs rebase anyway and this pull seems to be sufficiently reviewed.

@MarcoFalke sufficiently reviewed? All the ACKs were either untested or concept only from what I can see.

@rebroad, I think for a simple refactoring patch the following review is sufficient:

• OP checked for same binaries
• I checked for same binaries
• 5 people were reading the diff and utACKed, one was just Concept ACKing
• The automated tests passed
• I checked against all open pull request for 0.14 that no new conflicts are introduced

I do not understand why you call that insufficient.

On Wed, Feb 1, 2017 at 12:43 PM, R E Broadley notifications@github.com wrote:

@MarcoFalke https://github.com/MarcoFalke sufficiently reviewed? All the ACKs were either untested or concept only from what I can see.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9644#issuecomment-276637445, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmvzd2P94KQ5OD5Iqooo6c6zAeaAtiks5rYG_ngaJpZM4LvjgS .

@MarcoFalke thanks for clarifying