Whenever a block is received, log the sender's IP and the current time #966

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:log_block_sender_and_time changing 1 files +2 −2

luke-jr commented at 12:27 AM on March 21, 2012: member

No description provided.
Whenever a block is received, log the sender's IP and the current time 41cb872bbc
gmaxwell commented at 12:32 AM on March 21, 2012: contributor

Nak. :(

Logging IPs of identifying things by default would make it profitable to go around breaking into nodes in order to backtrace announcements.

However, I'd ack a non-default option to log IPs for blocks (and other things too) though.
TheBlueMatt commented at 12:32 AM on March 21, 2012: member

NACK - this makes it valuable to collect debug.log from user's systems to trace transactions/blocks back to IP Addresses, which should not be trivial.
gavinandresen commented at 1:25 AM on March 21, 2012: contributor

NACK.

RE: making it optional: maybe -blocknotify could optionally pass the IP into the notification method.
jgarzik commented at 1:26 PM on March 21, 2012: contributor

Plenty of NAK's, including mine
jgarzik closed this on Mar 21, 2012
luke-jr commented at 1:36 PM on March 21, 2012: member

Since it seems people are getting the wrong impression from this pullreq...

It was proposed by a pool member who noticed the mystery jerk miner (making transactionless blocks) was relaying them through Eligius. This handy-but-simple change enabled me to get the real IP of the actual server making these blocks. The objections given herein by other developers are logical concerns, and I have no qualms with the pullreq being closed unmerged.
suprnurd referenced this in commit f0140dab01 on Dec 5, 2017
ptschip referenced this in commit 0704d80c26 on Feb 13, 2018
DrahtBot locked this on Sep 8, 2021

Contributors