Set correct metadata on bumpfee wallet transactions #9673

1. 
   ryanofsky commented at 11:31 PM on February 2, 2017: member

   Preserve comment, order form, and account strings from the original wallet transaction. Also set fTimeReceivedIsTxTime and fFromMe fields for consistency with CWallet::CreateTransaction. The latter two fields don't influence current wallet behavior, but do record that the transaction originated in the wallet instead of coming from the network or sendrawtransaction.

   Some of the new code will be moved into CommitTransaction in #9680.

2. [wallet] Set correct metadata on bumpfee wallet transactions

   Preserve comment, order form, and account strings from the original wallet
   transaction. Also set fTimeReceivedIsTxTime and fFromMe fields for consistency
   with CWallet::CreateTransaction. The latter two fields don't influence current
   wallet behavior, but do record that the transaction originated in the wallet
   instead of coming from the network or sendrawtransaction.

   4ec057dfa7
3. MarcoFalke added this to the milestone 0.14.0 on Feb 3, 2017
4. fanquake added the label RPC/REST/ZMQ on Feb 3, 2017
5. fanquake added the label Wallet on Feb 3, 2017
6. ryanofsky force-pushed on Feb 3, 2017
7. 
   TheBlueMatt commented at 4:31 PM on February 3, 2017: member

   utACK dd12997a4f4221d4026b9b6f7ea4579db700c5b7

8. 
   MarcoFalke commented at 6:52 PM on February 3, 2017: member

   utACK dd12997a4f4221d4026b9b6f7ea4579db700c5b7

9. 
   ryanofsky commented at 7:15 PM on February 3, 2017: member

   Tweaked commit message (dd12997a4f4221d4026b9b6f7ea4579db700c5b7 -> 4ec057dfa72fbb910fec69305af1ff6d5e03ca30), no other changes.

10. 
    laanwj commented at 11:49 AM on February 6, 2017: member

    utACK 4ec057d

11. laanwj merged this on Feb 6, 2017
12. laanwj closed this on Feb 6, 2017

    ---

13. laanwj referenced this in commit 8d6447ecf7 on Feb 6, 2017
14. MarcoFalke locked this on Sep 8, 2021

Milestone
0.14.0