[wallet] Remove importmulti always-true check #9760

1. 
   ryanofsky commented at 3:33 pm on February 14, 2017: member

   No change in behavior.

   Remove nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax() check from importmulti, which is always true because nLowestTimestamp is set to the minimum of the most recent block time and all the imported key timestamps, which is necessarily lower than the maximum block time.

   An alternative would to make initialize nLowestTimestamp to numeric_limits<int64_t>::max() so the check would actually do what it appears to be intended to do, and avoid ScanForWalletTransactions calls when all the imported key timestamps are in the future.

2. fanquake added the label RPC/REST/ZMQ on Feb 14, 2017
3. fanquake added the label Wallet on Feb 14, 2017
4. 
   morcos commented at 3:39 pm on February 16, 2017: member

   utACK ee7caa0

   I’d prefer to merge this for 0.14 also so that a future code change doesn’t break the rescan because there is no grace period in this check.

5. laanwj added this to the milestone 0.14.0 on Feb 16, 2017
6. gmaxwell approved
7. 
   gmaxwell commented at 3:19 am on February 17, 2017: contributor

   utACK.
8. 
   laanwj commented at 11:55 am on February 17, 2017: member

   This has a merge conflict now, either due to #9778 or #9761
9. [wallet] Remove importmulti always-true check

   Remove "nLowestTimestamp <= chainActive.Tip()->GetBlockTimeMax()" check from
   importmulti, which is always true because nLowestTimestamp is set to the
   minimum of the most recent block time and all the imported key timestamps,
   which is necessarily lower than the maximum block time.

   ec1267f13b
10. ryanofsky force-pushed on Feb 17, 2017
11. 
    ryanofsky commented at 12:03 pm on February 17, 2017: member

    Rebased ee7caa09d3eb79b43e361f5c9d56836e40c64224 -> ec1267f13b7d0b9b5058c6821cf8dbf74e02d17c (multitaut.0 -> multitaut.1).

    Merge conflict was unrelated, but on an adjacent line to this one line change.

12. 
    jtimon commented at 11:18 pm on February 18, 2017: contributor

    utACK ec1267f
13. laanwj merged this on Feb 20, 2017
14. laanwj closed this on Feb 20, 2017

    ---

15. laanwj referenced this in commit 2dad02232a on Feb 20, 2017
16. laanwj referenced this in commit 40c754cb38 on Feb 20, 2017
17. codablock referenced this in commit 199b07a892 on Jan 26, 2018
18. andvgal referenced this in commit 46a2db629f on Jan 6, 2019
19. CryptoCentric referenced this in commit c8073b1930 on Feb 27, 2019
20. MarcoFalke locked this on Sep 8, 2021

Contributors
ryanofsky morcos gmaxwell laanwj jtimon

Labels
Wallet RPC/REST/ZMQ

Milestone
0.14.0