Document increase in memory usage due to mempool/dbcache sharing #9866

1. 
   TheBlueMatt commented at 5:16 PM on February 26, 2017: member

   No description provided.

2. 
   TheBlueMatt commented at 5:16 PM on February 26, 2017: member

   I believe this is a sufficient fix for #9857.

3. 
   paveljanik commented at 5:23 PM on February 26, 2017: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/9866/commits/1e9e320dc98a69661484842bfde9d1c24fb52ecb

   Maybe we should (in other PR) add a small doc about using Bitcoin Core on low-memory systems (recommendation for IBD, for normal run, blocksonly etc.).

4. 
   MarcoFalke commented at 5:36 PM on February 26, 2017: member

   ACK 1e9e320

5. MarcoFalke added the label Docs and Output on Feb 26, 2017
6. MarcoFalke added this to the milestone 0.14.0 on Feb 26, 2017
7. 
   laanwj commented at 8:16 PM on February 26, 2017: member

   utACK

   Maybe we should (in other PR) add a small doc about using Bitcoin Core on low-memory systems (recommendation for IBD, for normal run, blocksonly etc.).

   I have such a document though it's not been updated in a while so some things are probably no longer relevant.

8. gmaxwell approved
9. 
   gmaxwell commented at 8:31 PM on February 26, 2017: contributor

   ACK.

10. in doc/release-notes.md:None in 1e9e320dc9 outdated

     341 | @@ -342,6 +342,16 @@ Fundrawtransaction change address reuse
     342 |  - Users should also consider using `getrawchangeaddress()` in conjunction
     343 |    with `fundrawtransaction`'s `changeAddress` option.
     344 |  
     345 | +Unused mempool memory used by coincache
     346 | +----------------------------------------
     347 | +
     348 | +- Before 0.14, memory reserved for mempool (using the `-maxmempool` option)
     349 | +  went unused during initial block download. In 0.14, the UTXO DB cache
     350 | +  (controled with the `-dbcache` option) borrows memory from the mempool
    

    ---

    ---

    

    sdaftuar commented at 3:12 PM on February 27, 2017:

    nit: "controlled"

    ---

    

    TheBlueMatt commented at 7:15 PM on February 27, 2017:

    Fixed.

11. TheBlueMatt force-pushed on Feb 27, 2017
12. Document increase in memory usage due to mempool/dbcache sharing 50ae5c711a
13. in doc/release-notes.md:None in 919753c9d7 outdated

     347 | +
     348 | +- Before 0.14, memory reserved for mempool (using the `-maxmempool` option)
     349 | +  went unused during initial block download. In 0.14, the UTXO DB cache
     350 | +  (controlled with the `-dbcache` option) borrows memory from the mempool
     351 | +  when there is extra memory available. This may result in an increase in
     352 | +  memory usage during IBD for those previously relying on only the `-dbcache`
    

    ---

    ---

    

    sdaftuar commented at 7:57 PM on February 27, 2017:

    (Sorry for trickling my review comments, but I was about to ACK and then just noticed this:) Perhaps "IBD" is too much jargon for release notes?

    ---

    

    TheBlueMatt commented at 8:29 PM on February 27, 2017:

    Hmm, "initial block download" was mentioned a few lines up...I clarified there.

14. TheBlueMatt force-pushed on Feb 27, 2017
15. dcousens approved
16. 
    sipa commented at 11:18 PM on February 27, 2017: member

    ACK.

    It may be worth it to also update @laanwj's low-memory suggestions, and include it in the doc/ directory?

17. 
    laanwj commented at 10:45 AM on February 28, 2017: member

    It may be worth it to also update @laanwj's low-memory suggestions, and include it in the doc/ directory?

    Yes that would be useful, I planned to do that at some point when the document was ready. But it was never ready because things are always changing :)

18. laanwj merged this on Feb 28, 2017
19. laanwj closed this on Feb 28, 2017

    ---

20. laanwj referenced this in commit 1f83663bc2 on Feb 28, 2017
21. MarcoFalke locked this on Sep 8, 2021

Contributors

TheBlueMattpaveljanikMarcoFalkelaanwjgmaxwellsdaftuardcousenssipa

Milestone
0.14.0