TODO for release notes 0.15.0

MarcoFalke commented at 4:53 pm on February 28, 2017: member

Whenever possible, please amend the doc/release-notes.md within the pull that introduces a new fancy feature or breaks compatibility.

If this is not possible, please mention the pull here, so it can be taken care of later:

RBF GUI (#9592, …)
#9602: Remove coin age priority and free transactions
[wallet] Rescan abortability #10208 adds abortrescan RPC
leveldb 1.20 #10138
#9733 adds getchaintxstats RPC
#9966 adds -persistmempool option
#8952 adds query options to listunspent RPC
#10478 adds bindaddr address for peer connections to getpeerinfo
#9740 makes dumpwallet return the full absolute path to the dumped wallet
#10400 adds uptime command
Move transaction combining from signrawtransaction to new RPC #10571
Do not allow users to get keys from keypool without reserving them #10784

Feel free to edit

The release notes are now edited on the wiki:

https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes

MarcoFalke added the label Docs and Output on Feb 28, 2017

MarcoFalke added the label Needs release notes on Feb 28, 2017

MarcoFalke added this to the milestone 0.15.0 on Feb 28, 2017

NicolasDorier commented at 5:23 am on March 22, 2017: contributor

~~would like #9728~~

laanwj commented at 6:59 am on March 22, 2017: member

@NicolasDorier to be clear, this issue is to keep track of items that are already merged but need release notes updates

laanwj commented at 6:08 am on April 18, 2017: member

[wallet] Rescan abortability #10208 adds abortrescan RPC

jnewbery commented at 9:16 pm on April 19, 2017: member

#10204 changes an RPC argument name. It’s being backported to 0.14.1 - does it need 0.15 release notes as well, or do the 0.14.1 release notes cover it?

laanwj commented at 9:49 am on April 20, 2017: member

[net] Allow disconnectnode RPC to be called with node id #10143 adds nodeid argument

does it need 0.15 release notes as well, or do the 0.14.1 release notes cover it?

Things should only end up in one release notes at most: the first release that has them.

laanwj commented at 9:04 am on May 3, 2017: member

#9733 adds getchaintxstats RPC
#9966 adds -persistmempool option

laanwj commented at 7:13 am on May 17, 2017: member

#8952 adds query options to listunspent RPC

laanwj commented at 1:42 pm on June 5, 2017: member

#10478 adds bindaddr address for peer connections to getpeerinfo
#9740 makes dumpwallet return the full absolute path to the dumped wallet

TheBlueMatt commented at 4:17 pm on June 9, 2017: member

#10488 (and #10252) update the prioritizetransaction RPC API further after #9602, and the release notes for 9602 should include those changes as well.

laanwj commented at 9:35 am on June 27, 2017: member

#10400 adds uptime command

TheBlueMatt commented at 3:11 pm on July 11, 2017: member

Hopefully #10707 will make it, and will thus need release notes.

laanwj commented at 7:46 pm on July 13, 2017: member

Should add a release notes section about all the wonderful perf improvements in 0.15

new and better per-utxo database format, non-atomic flushing
tx validation caching (that’s massive for performance at the tip)
CRC instruction support in leveldb 1.20 (and more)

jtimon commented at 8:13 pm on July 13, 2017: contributor

What about something like “more progress reducing dependencies like boost after moving to c++11”? I remember #10502 and #10193 , but IIRC more work has done in this regard, right?

MarcoFalke commented at 8:27 pm on July 13, 2017: member

Boost will stick to us for a few releases at least. So this is just internal refactoring, irrelevant to release notes.

On Thu, Jul 13, 2017 at 10:14 PM, Jorge Timón notifications@github.com wrote:

What about something like “more progress reducing dependencies like boost after moving to c++11”? I remember #10502 https://github.com/bitcoin/bitcoin/pull/10502 and #10193 https://github.com/bitcoin/bitcoin/pull/10193 , but IIRC more work has done in this regard, right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/9889#issuecomment-315189343, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv3sCkjfJHv6l90R9ng8Saiy4xXjlks5sNnqIgaJpZM4MOpbC .

laanwj commented at 8:12 am on July 14, 2017: member

What about something like “more progress reducing dependencies like boost after moving to c++11”? I remember #10502 and #10193 , but IIRC more work has done in this regard, right?

In contrast to performance improvements, which are a good selling point for a release, it doesn’t seem an end-user would care about that.

After the dependency on boost completely goes away, sure, we should mention it for builders.

TheBlueMatt commented at 3:30 pm on July 18, 2017: member

#10784, if it makes it.

TheBlueMatt commented at 3:57 pm on July 23, 2017: member

#10571.

MarcoFalke commented at 8:57 pm on July 27, 2017: member

Due to request in yesterday’s meeting, the release notes can now be edited on the wiki:

https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes

jnewbery commented at 0:25 am on July 28, 2017: member

#10604 adds listwallets command

jnewbery commented at 4:22 am on July 31, 2017: member

I’ve added the following to the wiki:

multiwallet
-persistmempool
abortrescan
getchaintxstats
listwallets
uptime
listunspent has query_options argument
dumpwallet returns path of dump file.
getpeerinfo returns addrbind
disconnectnode has nodeid argument
combinerawtransaction
fundrawtransaction no longer takes reserveChangeKey
changes to estimatesmartfee
change priorisetransaction and submitblock argument names to dummy

Is one of the maintainers able to check the boxes in the Issue notes and strike through the individual comments for these items (so it’s clear what is left to be done)?

jnewbery commented at 6:04 am on July 31, 2017: member

Added a performance improvements section (https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes#performance-improvements):

per-TXO chainstate (#10195)
script caching (#10192)
leveldb v1.20 hardware accelerated CRC (#10138)
SHA256 hardware acceleration (#10821) @sipa suggested #9665 and #10249 as other performance wins, but I think they’re quite difficult to quantify as x% IBD/validation gain, so I’ve left them out of the performance improvement section. They could perhaps be included elsewhere in the release notes.

EDIT: #10557 should probably also be included in release notes. It would be good to benchmark.

jnewbery commented at 6:28 am on July 31, 2017: member

Added release notes for:

opt-in RBF in bitcoin-qt (#9592)
fee bumper in bitcoin-qt (#9697)

here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes#replace-by-fee-control-in-the-gui

jnewbery commented at 7:43 am on July 31, 2017: member

Added a section on ‘Removal of Coin Age Priority’ (#9602) here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes#removal-of-coin-age-priority.

I believe that completes Release Notes for everything that has been mentioned in this issue prior to this comment.

I think we still need release notes for:

~~upgrade advice/downgrade warnings. @luke-jr is currently writing this~~
- ~~I’d like this to include a note saying direct upgrade from 0.7 and earlier is not supported (https://github.com/bitcoin/bitcoin/pull/9822#issuecomment-281678689)~~
~~Various improvements to fee logic (perhaps @morcos can write this?) (#10199, #10589, #10706 and https://gist.github.com/morcos/d3637f015bc4e607e1fd10d8351e9f41)~~
~~#10148 (Use non-atomic flushing with block replay)~~

Possibly the following, although I’d say probably not:

#10557 (Make check to distinguish between orphan txs and old txs more efficient). It’s an implementation detail so perhaps not worth including unless it’s a big perf win.
#9665 (Use cached [compact] blocks to respond to getdata messages). It’s an implementation detail and difficult to quantify what the gains are from this.
#10249 (Switch CCoinsMap from boost to std unordered_map). An implementation detail, but if we can quantify the perf win it should go in the Performance Improvements section.

jonasschnelli commented at 9:03 am on July 31, 2017: contributor

GUI fee selection changed from slider to a dropdown supporting confirmations-targets up to 1008 https://github.com/bitcoin/bitcoin/pull/10769

MarcoFalke commented at 12:12 pm on July 31, 2017: member

Not sure if we need to mention the change from slider to dropdown. I think this GUI change is pretty self-explanatory.

On Mon, Jul 31, 2017 at 11:03 AM, Jonas Schnelli notifications@github.com wrote:

GUI fee selection changed from slider to a dropdown supporting confirmations-targets up to 1008 #10769 https://github.com/bitcoin/bitcoin/pull/10769

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/9889#issuecomment-319010230, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv0o3Hcb894cyQS0zbgruNV6ty7Qlks5sTZh7gaJpZM4MOpbC .

jnewbery commented at 0:54 am on August 1, 2017: member

Thanks to whoever updated the issue notes with the current status (@MarcoFalke I assume). I see two items were added: Move transaction combining from signrawtransaction to new RPC and Do not allow users to get keys from keypool without reserving them. Those are both mentioned in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes#low-level-rpc-changes. Do you think they deserve their own sections?

jnewbery commented at 0:58 am on August 1, 2017: member

Thanks @luke-jr for cleaning up my notes and adding the upgrade section. Your revision looks good. The only part of https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes/c8f33d3eafe9fe3da16f68a34dfaf7b0db85ed65 I’d disagree with is:

(Clients should, however, use positional arguments for submitblock in order to be compatible with BIP 22.)

I don’t think the release notes should dictate how users/clients access the RPCs. submitblock supports named arguments just like all other RPCs. Do you mind if we remove that part?

jnewbery commented at 3:28 am on August 1, 2017: member

I’ve added the changes to estimaterawfee: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes#changes-to-the-estimatesmartfee-and-estimaterawfee-apis. Ping @morcos for review.

EDIT: I see that estimaterawfee was actually added in this release cycle, so we should document the RPC as a new feature, rather than changes to an existing feature.

jamiewaltz commented at 3:31 am on August 1, 2017: none

Stop sending me emails please

On Jul 31, 2017 10:29 PM, “John Newbery” notifications@github.com wrote:

I’ve added the changes to estimaterawfee: https://github.com/bitcoin- core/bitcoin-devwiki/wiki/0.15.0-Release-notes#changes-to- the-estimatesmartfee-and-estimaterawfee-apis. Ping @morcos https://github.com/morcos for review.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/9889#issuecomment-319257829, or mute the thread https://github.com/notifications/unsubscribe-auth/AIYwnOdjrP-uukqKPFavhsr4emleBQ9_ks5sTpuTgaJpZM4MOpbC .

laanwj commented at 9:49 am on August 1, 2017: member

@jnewbery Wow, thanks for the release note updates! @MarcoFalke Thanks for creating the wiki page. @jamiewaltz Github provides an unsubscribe link in emails, as well as an “Unsubscribe” link when you go to the issue in question. Please use either ofthose. The only thing I can do is block you from the project completely, which is probably not what you want.

jnewbery commented at 7:15 pm on August 7, 2017: member

I’ve added a section on Fee Estimation Improvements: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.15.0-Release-notes#fee-estimation-improvements

Perhaps @morcos can review to make sure I’ve captured everything accurately.

MarcoFalke commented at 9:54 am on August 8, 2017: member

Going to close this. Looks like everything has been addressed.

Otherwise, just head over to the draft and fix it.

MarcoFalke closed this on Aug 8, 2017

laanwj commented at 10:51 pm on September 7, 2017: member

Seems continued in #11174 (not sure why not just reopening this one)

sipa removed the label Needs release notes on Aug 14, 2018

DrahtBot locked this on Sep 8, 2021

TODO for release notes 0.15.0 #9889