Two issues in travis: its gpg is too old to set --weak-digest and sort needs LC_ALL, not LANG. Also, this checks the Tree-SHA512 for the top commit always, and needs a contrib/trusted-sha512-root-commit update to work.
Fix verify-commits on travis and always check top commit's tree #9932
pull TheBlueMatt wants to merge 2 commits into bitcoin:master from TheBlueMatt:2017-03-fix-verify-commits changing 3 files +24 −11-
TheBlueMatt commented at 9:33 PM on March 6, 2017: member
-
MarcoFalke commented at 9:46 PM on March 6, 2017: member
weak digest was introduced in 1.4.20, no?
https://lists.gnupg.org/pipermail/gnupg-announce/2015q4/000382.html
On Mon, Mar 6, 2017 at 10:34 PM, Matt Corallo notifications@github.com wrote:
Two issues in travis: its gpg is too old to set --weak-digest and sort needs LC_ALL, not LANG. Also, this checks the Tree-SHA512 for the top commit always, and needs a contrib/trusted-sha512-root-commit update to work.
You can view, comment on, or merge this pull request online at:
#9932 Commit Summary
- Check gpg version before setting --weak-digest
- Fix bashisms in verify-commits and always check top commit's tree
File Changes
- M contrib/verify-commits/gpg.sh https://github.com/bitcoin/bitcoin/pull/9932/files#diff-0 (16)
- M contrib/verify-commits/trusted-sha512-root-commit https://github.com/bitcoin/bitcoin/pull/9932/files#diff-1 (2)
- M contrib/verify-commits/verify-commits.sh https://github.com/bitcoin/bitcoin/pull/9932/files#diff-2 (15)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9932, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv6uBpxzjeVx5sFnRiZVxh2k7D-lGks5rjHvPgaJpZM4MUuWG .
-
Check gpg version before setting --weak-digest f20e664f40
-
Fix bashisms in verify-commits and always check top commit's tree b3ec305f8e
- TheBlueMatt force-pushed on Mar 6, 2017
-
TheBlueMatt commented at 10:01 PM on March 6, 2017: member
OK, now it just checks if you're running gpg 2.0.X or 1.4.1X since those are the only reasonably-recent versions which do not have --weak-digest.
- fanquake added the label Scripts and tools on Mar 7, 2017
-
MarcoFalke commented at 9:18 AM on March 7, 2017: member
utACK b3ec305f8e298b86507100cf28f9c240a0d2139f
- laanwj merged this on Mar 7, 2017
- laanwj closed this on Mar 7, 2017
- laanwj referenced this in commit 00c13ea637 on Mar 7, 2017
- PastaPastaPasta referenced this in commit a0dab2d4c9 on Dec 30, 2018
- PastaPastaPasta referenced this in commit 9c2342d43e on Dec 31, 2018
- PastaPastaPasta referenced this in commit c16074de5d on Dec 31, 2018
- PastaPastaPasta referenced this in commit 6256f73db1 on Dec 31, 2018
- PastaPastaPasta referenced this in commit 1d2d7ceac9 on Jan 2, 2019
- PastaPastaPasta referenced this in commit 6fd2aa7d85 on Jan 2, 2019
- PastaPastaPasta referenced this in commit 6820a7753a on Jan 3, 2019
- PastaPastaPasta referenced this in commit f887e2112c on Jan 21, 2019
- PastaPastaPasta referenced this in commit 124e430a44 on Jan 29, 2019
- PastaPastaPasta referenced this in commit a55cc90a62 on Feb 5, 2019
- PastaPastaPasta referenced this in commit 8a436ec36a on Feb 5, 2019
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels