No description provided.
Add const to methods that do not modify the object for which it is called #9964
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:const changing 23 files +38 −38-
practicalswift commented at 12:47 PM on March 9, 2017: contributor
- fanquake added the label Refactoring on Mar 9, 2017
-
benma commented at 3:18 PM on March 9, 2017: none
isRestartRequired()inoptionsmodel.(h|cpp)can also be made const, I think. - practicalswift force-pushed on Mar 9, 2017
-
practicalswift commented at 3:48 PM on March 9, 2017: contributor
@benma Thanks! Added and pushed.
-
benma commented at 3:53 PM on March 9, 2017: none
utACK 17d6213f1ed08ce9907b90d22cc9596267eeeb73
- dcousens approved
- dcousens approved
-
dcousens commented at 2:57 AM on March 10, 2017: contributor
utACK
-
MarcoFalke commented at 10:49 AM on March 10, 2017: member
utACK 17d6213f1ed08ce9907b90d22cc9596267eeeb
-
paveljanik commented at 4:33 PM on March 14, 2017: contributor
utACK 17d6213
-
jtimon commented at 7:46 PM on March 18, 2017: contributor
utACK 17d6213f1ed08ce9907b90d22cc9596267eeeb73 (but if it compiles everything is correct, it is true that only adds const to methods that look like should be const).
-
practicalswift commented at 12:34 PM on April 10, 2017: contributor
Adding link to "By default, make member functions
const" (Con.2) in the C++ Core Guidelines. - practicalswift force-pushed on Jul 25, 2017
-
Add const to methods that do not modify the object for which it is called 6e8c48dc59
- practicalswift force-pushed on Jul 25, 2017
-
practicalswift commented at 11:48 AM on July 25, 2017: contributor
Added a few additional methods.
-
MarcoFalke commented at 1:10 PM on July 30, 2017: member
utACK 6e8c48dc593d8b6e5cebd15a980074715223b572
-
TheBlueMatt commented at 2:30 PM on July 30, 2017: member
utACK 6e8c48dc593d8b6e5cebd15a980074715223b572
-
paveljanik commented at 1:56 PM on August 11, 2017: contributor
re-utACK 6e8c48d
- MarcoFalke merged this on Aug 16, 2017
- MarcoFalke closed this on Aug 16, 2017
- MarcoFalke referenced this in commit b6a48914c5 on Aug 16, 2017
- PastaPastaPasta referenced this in commit 3a884346bb on Sep 19, 2019
- PastaPastaPasta referenced this in commit 415ef1b93b on Sep 23, 2019
- PastaPastaPasta referenced this in commit f79f375950 on Sep 24, 2019
- PastaPastaPasta referenced this in commit 3a365323c5 on Nov 19, 2019
- PastaPastaPasta referenced this in commit 20009e3b6b on Nov 21, 2019
- PastaPastaPasta referenced this in commit 7c3b9fa969 on Dec 9, 2019
- PastaPastaPasta referenced this in commit 26b9a6a29b on Jan 1, 2020
- PastaPastaPasta referenced this in commit 63e6138191 on Jan 2, 2020
- PastaPastaPasta referenced this in commit 0fe8343a2d on Jan 2, 2020
- PastaPastaPasta referenced this in commit 3b3830bf5a on Jan 2, 2020
- PastaPastaPasta referenced this in commit 8302bd5479 on Jan 2, 2020
- ckti referenced this in commit 4548e3f02a on Mar 28, 2021
- practicalswift deleted the branch on Apr 10, 2021
- gades referenced this in commit 6de88a2211 on Jun 26, 2021
- gades referenced this in commit fd3a1fa5c7 on Jan 29, 2022
- DrahtBot locked this on Aug 16, 2022
Labels