Makes the GUI transaction list more like the RPC, and IMO clearer in general.
As a side effect, this also fixes the GUI entries when a transaction is a net profit to us, but some inputs were also from us.
Originally https://github.com/bitcoin/bitcoin/pull/15115
Has Concept ACKs from @*Empact @*jonasschnelli
@luke-jr what’s the difference between raising a pull on this repository vs the bitcoin repository (as per your original 15115 pull request)? Sorry to ask this here but I’m unsure of where best to ask this.
Moving into the GUI repo was requested explicitly by @fanquake.
147+
148+ TransactionRecord sub(hash, nTime);
149+ sub.idx = i;
150+ sub.involvesWatchAddress = involvesWatchAddress;
151+
152+ if (!boost::get<CNoDestination>(&wtx.txout_address[i]))
When rebasing, please use std::get_if instead of boost::get here as refactoring work has been done to move away from the boost dependency in such cases, see: https://github.com/bitcoin/bitcoin/pull/20480/
0 if (!std::get_if<CNoDestination>(&wtx.txout_address[i]))
41+ isminetype fAllFromMe = ISMINE_SPENDABLE;
42+ bool any_from_me = false;
43+ if (wtx.is_coinbase) {
44+ fAllFromMe = ISMINE_NO;
45+ } else {
46+ any_from_me = false;
df1b5b8e33fa4b7f26eb7b47bcffb61837d77f28
remove, unnecessary
Getting:
terminate called after throwing an instance of ‘std::runtime_error’ what(): JSON value is not a string as expected Aborted
when trying to open bitcoin-qt after compiling 2bb4e30.
Edit: I’m getting this on master too
ACK 2bb4e3076342162cab9b359e020c7f189db9d399
Tested that it does indeed split up send-to-self payments.
Tested 2bb4e3076342162cab9b359e020c7f189db9d399 on Ubuntu 22.04:
the master branch:
this PR:
The first commit 880b15199fa2d5efb681017ab86620c657910d2d fails to compile:
0qt/transactionrecord.cpp: In static member function ‘static QList<TransactionRecord> TransactionRecord::decomposeTransaction(const interfaces::WalletTx&)’:
1qt/transactionrecord.cpp:46:22: error: ‘ISMINE_NO’ was not declared in this scope; did you mean ‘wallet::ISMINE_NO’?
2 46 | fAllFromMe = ISMINE_NO;
3 | ^~~~~~~~~
4 | wallet::ISMINE_NO
5In file included from qt/transactionrecord.cpp:10:
6./wallet/ismine.h:42:5: note: ‘wallet::ISMINE_NO’ declared here
7 42 | ISMINE_NO = 0,
8 | ^~~~~~~~~
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
No conflicts as of last run.
This changes behaviour (IMO for the better) in the case where some but not all inputs are from us, and the net amount is positive.
If we didn't send it, it can't possibly be change, even if that's the key's purpose
The first commit 880b151 fails to compile:
Fixed. Remaining commits are identical.
92- }
93- else
94- {
95- isminetype fAllToMe = ISMINE_SPENDABLE;
96+ if (fAllFromMe || !any_from_me) {
97 for (const isminetype mine : wtx.txout_is_mine)
In f3fbe99fcf90daec79d49fd5d868102dc99feb23 “GUI: TransactionRecord: Refactor to turn send-to-self into send+receive pairs”
This for loop seems to be duplicated from the one above. I think this could be refactored so that we don’t need to duplicate this work?
ACK 099dbe4224e0e896604e7f6901d0fc302b0bd3a0.
Going to merge it, leaving further improvements for follow-ups.