Fix checkbox layout in Create Wallet dialog #155

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:201218-i3 changing 1 files +4 −4
  1. hebasto commented at 11:36 PM on December 17, 2020: member

    From https://github.com/bitcoin/bitcoin/issues/20555#issuecomment-747742627:

    0.21.0rc3 compiled from source, Ubuntu 20.04 + i3: tested mainnet, testnet, and signet. created a descriptor wallet in qt, tested torv3 with addnode, and checked if anchors.dat is created on shutdown and removed on startup.

    I've noticed the "Advanced options" label being cut-off in the wallet creation dialog.

    This PR should fix this issue.

  2. qt: Align layout of checkboxes e71b656f31
  3. MarcoFalke commented at 6:21 AM on December 18, 2020: contributor

    cc @0xB10C

  4. 0xB10C commented at 7:43 AM on December 18, 2020: contributor

    This seems to fix it! Thanks.

    rc3: image

    pr155: image

  5. MarcoFalke commented at 7:53 AM on December 18, 2020: contributor

    review ACK e71b656f317f38ef0ba0874736f116dae39efc67

    didn't test

  6. MarcoFalke merged this on Dec 18, 2020
  7. MarcoFalke closed this on Dec 18, 2020

  8. jonasschnelli commented at 7:56 AM on December 18, 2020: contributor

    Shouldn't this be a flexible (stretch layout instead of fixed pixles?

  9. MarcoFalke referenced this in commit ef7a155cf0 on Dec 18, 2020
  10. MarcoFalke commented at 7:57 AM on December 18, 2020: contributor

    This can be reworked for 0.22, but I think for rc4 we should aim for a minimal fix

  11. hebasto commented at 8:00 AM on December 18, 2020: member

    Shouldn't this be a flexible (stretch layout instead of fixed pixles?

    The goal of this PR was the minimal fix as @MarcoFalke said. Besides, the issue has spotted on i3 window manager, and the real problem could be much deeper.

  12. hebasto deleted the branch on Dec 18, 2020
  13. jonasschnelli commented at 8:04 AM on December 18, 2020: contributor

    post merge utACK the fix. I missed the rc4 issue or 0.21 tag...

  14. sidhujag referenced this in commit b1e56504e0 on Dec 18, 2020
  15. ComputerCraftr referenced this in commit a714ad04f6 on Jan 3, 2021
  16. ComputerCraftr referenced this in commit ceaa047591 on Jan 5, 2021
  17. apoelstra referenced this in commit 796bfd613a on Sep 1, 2021
  18. apoelstra referenced this in commit 9f390eb9dd on Sep 18, 2021
  19. apoelstra referenced this in commit 492ed0947f on Sep 22, 2021
  20. bitcoin-core locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 13:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me