Use layout manager for Create Wallet dialog #171

1. 
   hebasto commented at 11:32 AM on January 1, 2021: member

   On master (e75f91eae3936269b40b4bfdfe540d5526270936) not using layout manager causes problems with resizing:

   

   Also text labels are not resized properly on some window managers (https://github.com/bitcoin/bitcoin/issues/20777), or if their lengths are changed (after translation).

   This PR introduces a standard layout manager for the "Create Wallet" dialog that fixes all layout issues (actually, the createwalletdialog.ui has been re-written from scratch):

   

   Additional visual changes:

   • advanced options are grouped in QGroupBox (https://github.com/bitcoin-core/gui/pull/96#issuecomment-726337165)
   • enabled the size grip

   Fix https://github.com/bitcoin/bitcoin/issues/20777

2. 
   Sjors commented at 3:34 PM on January 1, 2021: member

   tACK 3cbcb251c24afc707fe53c360dd7b3b3fd7055f0 on macOS 11.1 dark mode <img width="403" alt="Schermafbeelding 2021-01-01 om 20 17 49" src="https://user-images.githubusercontent.com/10217/103444949-718b4c00-4c6e-11eb-929a-2d42ebead230.png">

3. 
   dooglus commented at 1:11 AM on January 2, 2021: contributor

   Looks great now:

   

   When I resize the window it redraws like this:

   

4. MarcoFalke added this to the milestone 0.21.1 on Jan 2, 2021
5. MarcoFalke assigned jonasschnelli on Jan 4, 2021
6. 
   MarcoFalke commented at 4:07 PM on January 4, 2021: contributor

   Tagged for 0.21.1

7. 
   jarolrod commented at 3:49 AM on January 6, 2021: member

   Testing on macOS Big Sur 11.1 with Qt 5.15.2 I noticed some abnormalities concerning the resizing behavior and the text. Below are some screenshots comparing behavior of Master and PR. Looking at the PR screenshots you will notice:

   1. The Wallet Input Form does not stay in the top left corner and it does not resize. It just stays in the center of the window.
   2. The Advance Options Text is no longer Bold
   3. The Advanced Options and Wallet Name text are a different size

   Master <img width="374" alt="master-normal" src="https://user-images.githubusercontent.com/23396902/103726909-001e0700-4fa8-11eb-92dd-6aee9b2ec7ea.png">

   <img width="852" alt="master-resize" src="https://user-images.githubusercontent.com/23396902/103726914-0318f780-4fa8-11eb-9513-ae8ccb4e641d.png">

   PR <img width="394" alt="pr-normal" src="https://user-images.githubusercontent.com/23396902/103726994-2d6ab500-4fa8-11eb-94c2-da803234c96b.png">

   <img width="764" alt="pr-resize" src="https://user-images.githubusercontent.com/23396902/103727002-2f347880-4fa8-11eb-8c48-5a3d42547fde.png">

8. 
   jonatack commented at 11:31 AM on January 6, 2021: contributor

   Concept ACK

9. 
   luke-jr commented at 5:48 PM on January 6, 2021: member

   I would think the empty space belongs below the advanced-options group box...

10. qt: Use layout manager for Create Wallet dialog d4feb6812a
11. hebasto force-pushed on Jan 6, 2021
12. 
    hebasto commented at 9:50 PM on January 6, 2021: member

    Updated 3cbcb251c24afc707fe53c360dd7b3b3fd7055f0 -> d4feb6812a2707ef85d75dda4372086ec62eb922 (pr171.01 -> pr171.02, diff):

    • addressed @jarolrod's comment for macOS:

    The Wallet Input Form does not stay in the top left corner and it does not resize. It just stays in the center of the window.

    • addressed @luke-jr's comment:

    I would think the empty space belongs below the advanced-options group box...

    ---

    @jarolrod

    2. The Advance Options Text is no longer Bold

    3. The Advanced Options and Wallet Name text are a different size

    It is intended to left default parameters for the QGroupBox widget in order to make look-and-feel standard for a particular platform. We already use the same approach, see screenshots from macOS:

    ---

    OP screenshots updated.

13. 
    jarolrod commented at 10:18 PM on January 6, 2021: member

    ACK d4feb6812a2707ef85d75dda4372086ec62eb922

    Fixed the resizing issue on macOS for me. <img width="788" alt="Screen Shot 2021-01-06 at 5 16 04 PM" src="https://user-images.githubusercontent.com/23396902/103825429-08775000-5043-11eb-8d6f-89c9531a6c5e.png">

14. 
    Sjors commented at 4:56 PM on January 8, 2021: member

    re-tACK d4feb6812a2707ef85d75dda4372086ec62eb922

15. 
    promag commented at 5:00 PM on January 8, 2021: contributor

    Why not prevent vertical resize? Is there a guideline to support unnecessary vertical resize?

16. 
    hebasto commented at 5:18 PM on January 8, 2021: member

    Yes, vertical resize is unnecessary. But why restrict users?

    On Fri, 8 Jan 2021 at 19:00 João Barbosa notifications@github.com wrote:

    Why not prevent vertical resize? Is there a guideline to support unnecessary vertical resize?

    — You are receiving this because you authored the thread.

    Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/171#issuecomment-756873020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PXPXAOBV4GK6ZMVVZQKDSY422TANCNFSM4VQGTD6A .

    --

    -- Hennadii Stepanov

17. 
    laanwj commented at 1:56 PM on January 12, 2021: member

    Concept ACK

18. 
    promag commented at 9:24 AM on January 14, 2021: contributor

    Tested ACK d4feb6812a2707ef85d75dda4372086ec62eb922 on macos.

19. MarcoFalke merged this on Jan 21, 2021
20. MarcoFalke closed this on Jan 21, 2021

    ---

21. MarcoFalke referenced this in commit 0dba346a56 on Jan 21, 2021
22. hebasto deleted the branch on Jan 21, 2021
23. sidhujag referenced this in commit a271d8cf5b on Jan 21, 2021
24. apoelstra referenced this in commit 172149553a on Sep 21, 2021
25. apoelstra referenced this in commit 9a729f87f7 on Sep 21, 2021
26. apoelstra referenced this in commit c89caab283 on Sep 22, 2021
27. bitcoin-core locked this on Aug 16, 2022

Milestone
0.21.1