Long(V3) Onion address is not wrapped in peer details #262

issue ghost openend this issue on March 29, 2021
  1. ghost commented at 7:48 am on March 29, 2021: none

    In the upper right corner of the screenshot you can see that the long(V3) Onion address is not wrapped, but cut. Also, the colon before the port is missing, which is confusing.

    When you enlarge the detail window, you can see that wrapping automatically works, but only at word-breakpoints, e.g. space or colon.

    kein_doppelpunkt

    Copying the v3 Onion address and port with the mouse works fine, though. The complete address and port is copied.

  2. hebasto added the label Bug on Mar 29, 2021
  3. hebasto commented at 3:36 pm on March 29, 2021: member
    Will a contraction of presented address like fbuf3g…a27cad.onion:8333 work for you?
  4. ghost commented at 4:08 pm on March 29, 2021: none

    I would like it better, if the address would be longer than 28 31 characters (which is half of the onion V3 length 56 + : + 5 digit port number) it would get a linefeed wrap after the 28 31th character. I think this would fit well into the window, and there would be no information loss.

    But the whole address should be copy-able.

    I did not find another way to copy the address, aside of marking it in the details tab with the mouse (this was also the use case made me stumbling upon this issue).

    Alternatively, if right-cklicking the address in the main peer window column, there could be a context menu “copy to clipboard”. I would like that most.

  5. hebasto commented at 6:29 am on March 30, 2021: member

    @wodry

    Do you mind looking into #264?

  6. ghost commented at 6:41 pm on March 30, 2021: none

    Do you mind looking into #264?

    Have done, thank you very much. If this copy-menu is there, the detail window regarding the node address is not so important anymore, and I could live with a contracted address display like fbuf3g…a27cad.onion:8333 there.

  7. hebasto removed the label Bug on Apr 10, 2021
  8. hebasto added the label Design on Apr 10, 2021
  9. hebasto commented at 11:17 am on April 10, 2021: member

    @wodry

    … contracted address display like fbuf3g…a27cad.onion:8333 there.

    Done in #276.

  10. hebasto referenced this in commit 13d27b452d on Apr 19, 2021
  11. sidhujag referenced this in commit 3b2479c022 on Apr 19, 2021
  12. hebasto removed the label Design on May 8, 2021
  13. hebasto added the label UI on May 8, 2021
  14. hebasto added the label UX on May 8, 2021
  15. jarolrod commented at 4:50 am on July 6, 2021: member

    @wodry can this can be closed since #276 was merged?

    I could live with a contracted address display like fbuf3g…a27cad.onion:8333 there.

  16. ghost commented at 8:21 pm on July 6, 2021: none

    The use case I stumbled upon this issue was that I wanted to copy a peer address, and it was confusing to try to copy it from the details header where it was not wrapped.

    #276 (shorten address display with ‘…’ in the middle) is not regarding this issue.

    This issue would be solved with a copy entry in the addresses context menu. That was intended with #264, which was closed and then picked up in #318, which is still open, not merged. The “copy address” address context menu entry is missing in current master: screenshot From my point of view, this could be closed when #318 would be merged.

  17. ghost commented at 8:23 pm on July 6, 2021: none

    @wodry can this can be closed since #276 was merged?

    I could live with a contracted address display like fbuf3g…a27cad.onion:8333 there.

    You dropped the first part of my sentence:

    If this copy-menu is there, […] I could live with a contracted address display like fbuf3g…a27cad.onion:8333 there.”

  18. hebasto commented at 9:16 am on July 27, 2021: member

    If this copy-menu is there, […] I could live with a contracted address display like fbuf3g…a27cad.onion:8333 there.”

    The Qt widget which is used to represent peer addresses (i.e., peerWidget which is an instance of QTableView) by default supports copying from a cell to a clipboard with keyboard shortcuts – Ctrl+C on Linux/Windows, or ⌘+C on macOS.

    So, the requested functionality is available in the code base. The new “Copy Address” context menu item just adds another way to perform the same action.

  19. PastaPastaPasta referenced this in commit 86c19334ec on Oct 20, 2021
  20. PastaPastaPasta referenced this in commit f8802b4a5d on Oct 21, 2021
  21. pravblockc referenced this in commit 90c6e996f1 on Nov 18, 2021
  22. gades referenced this in commit ac3b2a7244 on May 9, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me