refactor: Signal-slot connections cleanup #333

1. 
   hebasto commented at 9:33 pm on May 15, 2021: member

   This PR:

   • removes slots whose only job is to emit a signal, since we can use the signal as a slot
   • connects theWalletView::outOfSyncWarningClicked signal to the BitcoinGUI::showModalOverlay slot directly, and removes intermediate WalletFrame slot and signal
   • split from #29

   This PR does not change behavior.

2. hebasto added the label Refactoring on May 15, 2021
3. hebasto added the label Wallet on May 15, 2021
4. 
   jarolrod commented at 0:11 am on May 18, 2021: member

   ACK faf0639b168b22df7ff92e57c766b89a231d7483

   Reviewed the code and tested that each commit can compile and run on its own. Also tested to ensure there is no change in functionality. This is a nice simplification of the signal/slot logic

5. 
   hebasto commented at 11:57 am on May 29, 2021: member

   @promag @ryanofsky @Sjors @Talkless

   Could you look into this PR, please?

6. qt: Drop redundant WalletView::requestedSyncWarningInfo slot

   This change makes a connection directly to the signal that was emitted
   in the removed slot.
   
   This commit does not change behavior.

   793f19599b
7. qt: Drop redundant OverviewPage::handleOutOfSyncWarningClicks slot

   This change makes a connection directly to the signal that was emitted
   in the removed slot.
   
   This commit does not change behavior.

   bd50ff9290
8. qt: Connect WalletView signal to BitcoinGUI slot directly

   This change removes redundant intermediate WalletFrame connections.
   
   This commit does not change behavior.

   f507681baa
9. hebasto force-pushed on Jun 5, 2021
10. 
    hebasto commented at 10:07 pm on June 5, 2021: member

    Rebased faf0639b168b22df7ff92e57c766b89a231d7483 -> f507681baa406046c9c3d44be39e99124a2d6e5f (pr333.01 -> pr333.02) due to the conflict with #29.
11. Talkless approved
12. 
    Talkless commented at 6:35 pm on June 10, 2021: none

    tACK f507681baa406046c9c3d44be39e99124a2d6e5f, tested on Debian Sid with Qt 5.15.2, no any behavioral changes noticed.
13. 
    promag commented at 10:32 pm on June 11, 2021: contributor

    Code review ACK f507681baa406046c9c3d44be39e99124a2d6e5f.
14. hebasto merged this on Jun 12, 2021
15. hebasto closed this on Jun 12, 2021

    ---

16. sidhujag referenced this in commit 990da14083 on Jun 13, 2021
17. gwillen referenced this in commit 525ef7f1db on Jun 1, 2022
18. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto jarolrod Talkless promag

Labels
Refactoring Wallet