Fix gui segfault caused by bitcoin/bitcoin#22216 #361

1. 
   ryanofsky commented at 7:40 pm on June 11, 2021: contributor

   Reported by Hennadii Stepanov https://github.com/bitcoin/bitcoin/pull/22216#issuecomment-859790682

   Fixes bitcoin/bitcoin#22227

2. Fix gui segfault caused by bitcoin/bitcoin#22216

   Reported by Hennadii Stepanov https://github.com/bitcoin/bitcoin/pull/22216#issuecomment-859790682
   
   Fixes bitcoin/bitcoin#22227

   d7f3b1af21
3. 
   hebasto commented at 7:43 pm on June 11, 2021: member

   Why tests and CI did not catch it?
4. 
   ryanofsky commented at 7:45 pm on June 11, 2021: contributor

   Tests would not catch it because tests initialize context differently than the gui app.

   I didn’t catch it because I only tested the gui with bitcoin/bitcoin#22216 and bitcoin/bitcoin#22219 together. They were initially part of the same PR and bitcoin/bitcoin#22219 also fixes this bug a different way.

5. hebasto approved
6. 
   hebasto commented at 7:57 pm on June 11, 2021: member

   ACK d7f3b1af21daa93165b3726fee059a55b7727280, tested on Linux Mint 20.1 (Qt 5.12.8).

   UPDATE: tested on Windows 10 Pro (20H2, build 19042.1052).

7. hebasto added the label Bug on Jun 11, 2021
8. hebasto added the label Wallet on Jun 11, 2021
9. 
   jarolrod commented at 8:25 pm on June 11, 2021: member

   ACK d7f3b1af21daa93165b3726fee059a55b7727280

   Tested on macOS 11.3, Qt 5.15.2

   master:

   0xyz@xyzs-MBP bitcoin % ./src/qt/bitcoin-qt -testnet
   1dbus[52399]: Dynamic session lookup supported but failed: launchd did not provide a socket path, verify that org.freedesktop.dbus-session.plist is loaded!
   2Assertion failed: ("node.args" && check), function operator(), file wallet/init.cpp, line 127.
   3zsh: abort      ./src/qt/bitcoin-qt -testnet
   

   pr: Runs and works fine upon manual testing

10. hebasto merged this on Jun 11, 2021
11. hebasto closed this on Jun 11, 2021

    ---

12. sidhujag referenced this in commit f194dc2845 on Jun 12, 2021
13. 
    Rspigler commented at 7:10 pm on July 9, 2021: contributor

    Tests would not catch it because tests initialize context differently than the gui app.

    Is there a way to improve tests so that they initialize in the same way?

14. 
    ryanofsky commented at 7:22 pm on July 9, 2021: contributor

    Is there a way to improve tests so that they initialize in the same way?

    One way would be to make the python tests invoke bitcoin-qt. I believe this kind of already works if you set BITCOIND=qt/bitcoin-qt, but this isn’t run as part of CI currently

15. gwillen referenced this in commit 5ccf33b742 on Jun 1, 2022
16. bitcoin-core locked this on Aug 16, 2022

Contributors
ryanofsky hebasto jarolrod Rspigler

Labels
Bug Wallet