Control changes from clickable to unclickable upon canceling. #392

issue katesalazar openend this issue on August 2, 2021

katesalazar commented at 1:32 pm on August 2, 2021: contributor

Load a wallet, “Settings” > “Encrypt Wallet…” can be clicked. Click it, modal opens, cancel modal, now “Settings” > “Encrypt Wallet…” cannot be clicked (“disabled grey”).

Expected behavior

The control being disabled from the beginning.

Actual behavior

Control started clickable and idempotence not happening until after having clicked the control.

To reproduce

Open Bitcoin GUI, load the wallet (if not loaded). Close Bitcoin GUI. Open it again so that it loads the wallet automatically. Reproduce. After closing the wallet, the issue doesn’t happen anymore by reloading the wallet, until closing Bitcoin GUI and launching it again.

System information

This is v22.0rc1 built from sources, but I can check master and previous tags as necessary. I’d say the 0.21.1 tag is free from this behavior.

This is Debian Buster (10) right on top of the amd64 metal.

Qt reports 5.11.3, Plasma is 5.14.5 (I think).

I’d be bisecting this soon.
katesalazar added the label Bug on Aug 2, 2021
hebasto added this to the milestone 22.0 on Aug 3, 2021
hebasto commented at 12:53 pm on August 3, 2021: member

@katesalazar

Thank you for your report!

Load a wallet, “Settings” > “Encrypt Wallet…” can be clicked. Click it, modal opens, cancel modal, now “Settings” > “Encrypt Wallet…” cannot be clicked (“disabled grey”).

~Tested 22.0rc1, 22.0rc2 and master on Linux Mint 20.2 (Qt 5.12.8) – cannot reproduce the bug you described. Wallet details: the only wallet is loaded automatically during the GUI startup.~

~Will test on other systems.~

UPDATE: #392 (comment)
katesalazar commented at 4:21 pm on August 3, 2021: contributor

I finally ended running git bisect, reaching https://github.com/bitcoin-core/gui/commit/20e2e24e90. 🤔
katesalazar commented at 4:33 pm on August 3, 2021: contributor

I had been using a production wallet for this.

I just created and encrypted an empty wallet, and the same thing is happening to it. When trying to force the way to encrypt the encrypted empty wallet it’s showing this modal:

“Wallet encryption failed” “Wallet encryption failed due to an internal error. Your wallet was not encrypted.” “[ OK ]”
hebasto commented at 4:42 pm on August 3, 2021: member

I misread the issue description.

I can confirm this bug with encrypted wallet.
hebasto commented at 7:31 pm on August 3, 2021: member

@katesalazar

Fixed in #393. Do you mind testing it?
katesalazar commented at 7:38 pm on August 3, 2021: contributor
I think bringing back line
```
connect(walletView, &WalletView::encryptionStatusChanged, gui, &BitcoinGUI::updateWalletStatus);
```
of https://github.com/bitcoin/bitcoin/commit/20e2e24e90 removes the issue. But I don’t understand the implications and how that fits with the rest of that refactoring.
hebasto added the label UX on Aug 3, 2021
hebasto commented at 7:51 pm on August 3, 2021: member
@katesalazar
I think bringing back line

0connect(walletView, &WalletView::encryptionStatusChanged, gui, &BitcoinGUI::updateWalletStatus);
of bitcoin/bitcoin@20e2e24 removes the issue. But I don’t understand the implications and how that fits with the rest of that refactoring.
You are right. In #393 I just try to keep all connect calls grouped.
katesalazar commented at 8:26 pm on August 3, 2021: contributor

@katesalazar

Fixed in #393. Do you mind testing it?

I tested it and the bug was gone.

Then just to be sure I reverted it and the bug was back as expected.
hebasto commented at 8:59 pm on August 3, 2021: member

@katesalazar

I tested it and the bug was gone.

Then just to be sure I reverted it and the bug was back as expected.

Thanks for testing!

Could you leave a comment in #393?
hebasto added the label Wallet on Aug 4, 2021
jarolrod commented at 4:29 am on August 5, 2021: member

Confirming this bug on master
hebasto closed this on Aug 5, 2021
bitcoin-core locked this on Aug 16, 2022

Contributors
katesalazar hebasto jarolrod

Labels
Bug Wallet UX

Milestone
22.0