Control changes from clickable to unclickable upon canceling. #392

1. 
   katesalazar commented at 1:32 PM on August 2, 2021: contributor

   <!-- Describe the issue -->

   Load a wallet, "Settings" > "Encrypt Wallet..." can be clicked. Click it, modal opens, cancel modal, now "Settings" > "Encrypt Wallet..." cannot be clicked ("disabled grey").

   Expected behavior

   <!--- What behavior did you expect? -->

   The control being disabled from the beginning.

   Actual behavior

   <!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

   Control started clickable and idempotence not happening until after having clicked the control.

   To reproduce

   <!--- How reliably can you reproduce the issue, what are the steps to do so? -->

   Open Bitcoin GUI, load the wallet (if not loaded). Close Bitcoin GUI. Open it again so that it loads the wallet automatically. Reproduce. After closing the wallet, the issue doesn't happen anymore by reloading the wallet, until closing Bitcoin GUI and launching it again.

   System information

   <!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

   This is v22.0rc1 built from sources, but I can check master and previous tags as necessary. I'd say the 0.21.1 tag is free from this behavior.

   <!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

   This is Debian Buster (10) right on top of the amd64 metal.

   <!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->

   Qt reports 5.11.3, Plasma is 5.14.5 (I think).

   <!-- Any extra information that might be useful in the debugging process. -->

   I'd be bisecting this soon.

   <!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

2. katesalazar added the label Bug on Aug 2, 2021
3. hebasto added this to the milestone 22.0 on Aug 3, 2021
4. 
   hebasto commented at 12:53 PM on August 3, 2021: member

   @katesalazar

   Thank you for your report!

   Load a wallet, "Settings" > "Encrypt Wallet..." can be clicked. Click it, modal opens, cancel modal, now "Settings" > "Encrypt Wallet..." cannot be clicked ("disabled grey").

   ~Tested 22.0rc1, 22.0rc2 and master on Linux Mint 20.2 (Qt 5.12.8) -- cannot reproduce the bug you described. Wallet details: the only wallet is loaded automatically during the GUI startup.~

   ~Will test on other systems.~

   UPDATE: #392 (comment)

5. 
   katesalazar commented at 4:21 PM on August 3, 2021: contributor

   I finally ended running git bisect, reaching https://github.com/bitcoin-core/gui/commit/20e2e24e90. 🤔

6. 
   katesalazar commented at 4:33 PM on August 3, 2021: contributor

   I had been using a production wallet for this.

   I just created and encrypted an empty wallet, and the same thing is happening to it. When trying to force the way to encrypt the encrypted empty wallet it's showing this modal:

   "Wallet encryption failed" "Wallet encryption failed due to an internal error. Your wallet was not encrypted." "[ OK ]"

7. 
   hebasto commented at 4:42 PM on August 3, 2021: member

   I misread the issue description.

   I can confirm this bug with encrypted wallet.

8. 
   hebasto commented at 7:31 PM on August 3, 2021: member

   @katesalazar

   Fixed in #393. Do you mind testing it?

9. 
   katesalazar commented at 7:38 PM on August 3, 2021: contributor

   I think bringing back line

   connect(walletView, &WalletView::encryptionStatusChanged, gui, &BitcoinGUI::updateWalletStatus);

   of https://github.com/bitcoin/bitcoin/commit/20e2e24e90 removes the issue. But I don't understand the implications and how that fits with the rest of that refactoring.

10. hebasto added the label UX on Aug 3, 2021
11. 
    hebasto commented at 7:51 PM on August 3, 2021: member

    @katesalazar

    I think bringing back line

    connect(walletView, &WalletView::encryptionStatusChanged, gui, &BitcoinGUI::updateWalletStatus);
    

    of bitcoin/bitcoin@20e2e24 removes the issue. But I don't understand the implications and how that fits with the rest of that refactoring.

    You are right. In #393 I just try to keep all connect calls grouped.

12. 
    katesalazar commented at 8:26 PM on August 3, 2021: contributor

    @katesalazar

    Fixed in #393. Do you mind testing it?

    I tested it and the bug was gone.

    Then just to be sure I reverted it and the bug was back as expected.

13. 
    hebasto commented at 8:59 PM on August 3, 2021: member

    @katesalazar

    I tested it and the bug was gone.

    Then just to be sure I reverted it and the bug was back as expected.

    Thanks for testing!

    Could you leave a comment in #393?

14. hebasto added the label Wallet on Aug 4, 2021
15. 
    jarolrod commented at 4:29 AM on August 5, 2021: member

    Confirming this bug on master

16. hebasto closed this on Aug 5, 2021

    ---

17. bitcoin-core locked this on Aug 16, 2022

Milestone
22.0