Change “Open Wallet” popup text #679

issue mmikeww openend this issue on November 13, 2022
  1. mmikeww commented at 4:52 pm on November 13, 2022: none

    Is your feature request related to a problem? Please describe.

    When I use the menu for File -> Open Wallet, I get a popup saying “Opening wallet xxx….” with a progress bar. There is no other information. The progress bar just loops endlessly. I can of course close this popup by clicking the X normally. If I try to use the menu item again, I get the same popup and the same looping progress bar.

    image

    Initially I thought this was a bug, and was in the process of submitting a bug report, until I checked debug.log. I shouldn’t have to check a log file to understand whats happening. Inside I found these lines:

    02022-11-13T16:24:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 752699. Progress=0.977750
    12022-11-13T16:25:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753057. Progress=0.978535
    22022-11-13T16:26:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753399. Progress=0.979322
    32022-11-13T16:27:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753844. Progress=0.980183
    

    Waiting until this process completed allowed the wallet to open.

    Describe the solution you’d like

    I think the text on that popup window should be changed to be more descriptive for the user. The current text of “Opening wallet…..” with nothing but a looping progress bar, initially led me to believe that the wallet file was corrupted or something. That maybe Core couldn’t open it, and was just hung or looped.

    The text should be changed to something like “Syncing wallet with chain…” or however you want to word it, additionally with a progress bar that show’s the actual percentage like is shown inside the log file.

  2. mmikeww added the label Feature on Nov 13, 2022
  3. hebasto added the label Wallet on Nov 14, 2022
  4. katesalazar commented at 6:18 pm on November 14, 2022: contributor
    • a “more details” button that once clicked shows:
      • the “At block #i” log lines
      • and the AddToWallet lines

    On Sun, Nov 13, 2022 at 5:52 PM mmikeww @.***> wrote:

    Is your feature request related to a problem? Please describe.

    When I use the menu for File -> Open Wallet, I get a popup saying “Opening wallet xxx….” with a progress bar. There is no other information. The progress bar just loops endlessly. I can of course close this popup by clicking the X normally. If I try to use the menu item again, I get the same popup and the same looping progress bar.

    [image: image] https://user-images.githubusercontent.com/1900684/201532617-65bb175a-51df-4a9f-991b-d55740384c09.png

    Initially I thought this was a bug, and was in the process of submitting a bug report, until I checked debug.log. I shouldn’t have to check a log file to understand whats happening. Inside I found these lines:

    2022-11-13T16:24:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 752699. Progress=0.977750 2022-11-13T16:25:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753057. Progress=0.978535 2022-11-13T16:26:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753399. Progress=0.979322 2022-11-13T16:27:26Z [specter3c64f804925fff38\mymultisig] Still rescanning. At block 753844. Progress=0.980183

    Waiting until this process completed allowed the wallet to open.

    Describe the solution you’d like

    I think the text on that popup window should be changed to be more descriptive for the user. The current text of “Opening wallet…..” with nothing but a looping progress bar, initially led me to believe that the wallet file was corrupted or something. That maybe Core couldn’t open it, and was just hung or looped.

    The text should be changed to something like “Syncing wallet with chain…” or however you want to word it, additionally with a progress bar that show’s the actual percentage like is shown inside the log file.

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/issues/679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W574QJVNG7MJDYC7TDWIEMD5ANCNFSM6AAAAAAR7DQANM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

  5. pablomartin4btc commented at 3:57 pm on September 20, 2023: contributor
    This is kind of duplicated with #651, but I appreciate the level of details, I agree with the change of the title of the window + updating the progress bar with the actual progress to enhance accuracy but to avoid confusion as well.
  6. pablomartin4btc cross-referenced this on Sep 20, 2023 from issue Progress for opening wallet by fanquake

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me