clang-tidy: Fix `readability-redundant-string-init` in headers #685

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:221215-tidy-string changing 1 files +2 −2
  1. hebasto commented at 9:36 PM on December 15, 2022: member

    Split from bitcoin/bitcoin#26705 as was requested in https://github.com/bitcoin/bitcoin/pull/26705#issuecomment-1353293405.

    To test this PR, consider applying a diff as follows:

    --- a/src/.clang-tidy
    +++ b/src/.clang-tidy
    @@ -12,17 +12,9 @@ readability-redundant-declaration,
     readability-redundant-string-init,
     '
     WarningsAsErrors: '
    -bugprone-argument-comment,
    -bugprone-use-after-move,
    -misc-unused-using-decls,
    -modernize-use-default-member-init,
    -modernize-use-nullptr,
    -performance-for-range-copy,
    -performance-move-const-arg,
    -performance-unnecessary-copy-initialization,
    -readability-redundant-declaration,
     readability-redundant-string-init,
     '
     CheckOptions:
      - key: performance-move-const-arg.CheckTriviallyCopyableMove
        value: false
    +HeaderFilterRegex: '.'
    
  2. clang-tidy: Fix `readability-redundant-string-init` in headers
    See https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-string-init.html
    c39619eeb4
  3. DrahtBot commented at 9:36 PM on December 15, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. hebasto cross-referenced this on Dec 15, 2022 from issue clang-tidy: Fix `modernize-use-default-member-init` in headers and force to check all headers by hebasto
  5. maflcko commented at 8:13 AM on December 16, 2022: contributor

    review ACK c39619eeb4e615eb991143edb99e031dd562d0f6

  6. maflcko merged this on Dec 16, 2022
  7. maflcko closed this on Dec 16, 2022

  8. hebasto deleted the branch on Dec 16, 2022
  9. sidhujag referenced this in commit 5bcd427ef5 on Dec 16, 2022
  10. bitcoin-core locked this on Dec 16, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 13:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me