refactor: Disable unused special members functions in UnlockContext #711

1. 
   hebasto commented at 5:59 pm on February 14, 2023: member

   Also UnlockContext::valid and UnlockContext::relock are const now.
2. refactor: Disable unused special members functions in `UnlockContext` 9fa43b5af6
3. 
   DrahtBot commented at 5:59 pm on February 14, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	john-moffett, furszy, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin/bitcoin/26642 (clang-tidy: Add more performance-* checks and related fixes by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. hebasto added the label Wallet on Feb 14, 2023
5. hebasto cross-referenced this on Feb 14, 2023 from issue clang-tidy: Add more `performance-*` checks and related fixes by hebasto
6. 
   hebasto commented at 7:40 pm on February 14, 2023: member

   Friendly ping @achow101 @furszy @john-moffett @Sjors :)
7. john-moffett approved
8. 
   john-moffett commented at 2:08 pm on February 15, 2023: contributor

   ACK 9fa43b5af6b180f4b5f76726f443ee60259d2cd0
9. furszy approved
10. 
    furszy commented at 3:53 pm on February 15, 2023: member

    ACK 9fa43b5a
11. 
    achow101 commented at 11:27 pm on February 15, 2023: member

    ACK 9fa43b5af6b180f4b5f76726f443ee60259d2cd0
12. achow101 merged this on Feb 15, 2023
13. achow101 closed this on Feb 15, 2023

    ---

14. hebasto deleted the branch on Feb 16, 2023
15. sidhujag referenced this in commit 262b6bfce4 on Feb 16, 2023
16. 
    jonatack commented at 5:42 pm on February 16, 2023: contributor

    Post-merge ACK and nice application of the rule of five.
17. ftrader referenced this in commit 0b2831161a on Jun 8, 2023
18. bitcoin-core locked this on Feb 16, 2024

Contributors
hebasto DrahtBot john-moffett furszy achow101 jonatack

Labels
Wallet