Also UnlockContext::valid and UnlockContext::relock are const now.
refactor: Disable unused special members functions in `UnlockContext` #711
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230214-unlock changing 2 files +8 −17-
hebasto commented at 5:59 PM on February 14, 2023: member
-
refactor: Disable unused special members functions in `UnlockContext` 9fa43b5af6
-
DrahtBot commented at 5:59 PM on February 14, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK john-moffett, furszy, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #bitcoin/bitcoin/26642 (clang-tidy: Add more
performance-*checks and related fixes by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- #bitcoin/bitcoin/26642 (clang-tidy: Add more
- hebasto added the label Wallet on Feb 14, 2023
- hebasto cross-referenced this on Feb 14, 2023 from issue clang-tidy: Add more `performance-*` checks and related fixes by hebasto
-
hebasto commented at 7:40 PM on February 14, 2023: member
Friendly ping @achow101 @furszy @john-moffett @Sjors :)
- john-moffett approved
-
john-moffett commented at 2:08 PM on February 15, 2023: contributor
ACK 9fa43b5af6b180f4b5f76726f443ee60259d2cd0
- furszy approved
-
furszy commented at 3:53 PM on February 15, 2023: member
ACK 9fa43b5a
-
achow101 commented at 11:27 PM on February 15, 2023: member
ACK 9fa43b5af6b180f4b5f76726f443ee60259d2cd0
- achow101 merged this on Feb 15, 2023
- achow101 closed this on Feb 15, 2023
- hebasto deleted the branch on Feb 16, 2023
- sidhujag referenced this in commit 262b6bfce4 on Feb 16, 2023
-
jonatack commented at 5:42 PM on February 16, 2023: contributor
Post-merge ACK and nice application of the rule of five.
- ftrader referenced this in commit 0b2831161a on Jun 8, 2023
- bitcoin-core locked this on Feb 16, 2024
