Remove BDB checkbox in wallet creation dialog #763

1. 
   maflcko commented at 1:53 pm on October 5, 2023: contributor

   Please describe the feature you’d like to see added.

   With BDB being removed soon, it seems confusing and harmful to allow users to create fresh BDB wallets going forward, as it would load them with an additional burden of having to migrate them soon after.

   Is your feature related to a problem, if so please describe it.

   No response

   Describe the solution you’d like

   Remove BDB checkbox

   Describe any alternatives you’ve considered

   No response

   Please leave any additional context

   Power users can still create BDB wallets in the meantime, if they really want to, with an older release, or in the RPC console.

2. maflcko added the label Feature on Oct 5, 2023
3. maflcko added this to the milestone 26.0 on Oct 5, 2023
4. 
   hebasto commented at 1:54 pm on October 5, 2023: member

   Concept ACK.
5. 
   hebasto commented at 1:55 pm on October 5, 2023: member

   cc @achow101 @Sjors
6. hebasto added the label Wallet on Oct 5, 2023
7. 
   furszy commented at 1:57 pm on October 5, 2023: member

   Could also only show the check box when the deprecatedrpc=create_bdb (https://github.com/bitcoin/bitcoin/pull/28597) is enabled.
8. 
   maflcko commented at 1:59 pm on October 5, 2023: contributor

   Could also only show the check box when the deprecatedrpc=create_bdb (bitcoin/bitcoin#28597) is enabled.

   Sure, no objection. Though, if someone is enough of an expert to set the setting, they can also figure out how to use the RPC?

9. 
   hebasto commented at 1:59 pm on October 5, 2023: member

   @furszy

   Want to submit a PR?

10. 
    Sjors commented at 2:49 pm on October 5, 2023: member

    Concept ACK

    I also think people should use the RPC if the really want a legacy wallet.

    (and I suspect we can drop a little bit of code complexity because fewer combinations of checkboxes are possible)

11. hebasto closed this on Oct 7, 2023

    ---

12. hernanmarino referenced this in commit d2b8c5e123 on Jan 30, 2024
13. bitcoin-core locked this on Oct 6, 2024

Contributors
maflcko hebasto furszy Sjors

Labels
Feature Wallet

Milestone
26.0