qt: Add addressList field to SendCoinsRecipient for multiple addresses #857

pull VolodymyrBg wants to merge 4 commits into bitcoin-core:master from VolodymyrBg:BG changing 4 files +56 −13
  1. VolodymyrBg commented at 6:36 pm on March 11, 2025: none

    This pull request adds a new field addressList to the SendCoinsRecipient class to properly handle multiple addresses from unauthenticated payment requests. Previously, the address field was being abused for this purpose, as noted in a TODO comment.

    The changes include:

    • Adding a new addressList field to SendCoinsRecipient
    • Updating the serialization methods to handle the new field
    • Modifying PaymentServer to populate the new field when multiple addresses are present
    • Updating ReceiveRequestDialog to display and copy the address list when available
    • Adding support for the “addresses” parameter in Bitcoin URI parsing This provides a cleaner solution for handling multiple addresses in payment requests without abusing the single address field.
  2. Update guiutil.cpp 99501f6979
  3. Update paymentserver.cpp 01944a5890
  4. Update receiverequestdialog.cpp 0a8fa64ae8
  5. Update sendcoinsrecipient.h ac1b3bddd3
  6. DrahtBot commented at 6:36 pm on March 11, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  7. DrahtBot added the label CI failed on Mar 11, 2025
  8. DrahtBot commented at 7:58 pm on March 11, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin-core/gui/runs/38586514593

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-12 09:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me