Replace stray tfm::format to cerr with qWarning #868

pull laanwj wants to merge 1 commits into bitcoin-core:master from laanwj:2025-05-qt-stray-format changing 1 files +1 −1
  1. laanwj commented at 10:38 am on April 24, 2025: member
    GUI warnings should go to the log, not to the console (which may not be connected at all).
  2. qt: Replace stray tfm::format to cerr with qWarning
    GUI warnings should go to the log, not to the console (which may not be
    connected at all).
    edd46566bd
  3. laanwj added the label Wallet on Apr 24, 2025
  4. DrahtBot commented at 10:38 am on April 24, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hebasto renamed this:
    qt: Replace stray tfm::format to cerr with qWarning
    Replace stray tfm::format to cerr with qWarning
    on Apr 24, 2025
  6. hebasto approved
  7. hebasto commented at 6:02 pm on April 25, 2025: member
    ACK edd46566bd66cea7d7f4116429fe1c11d2187ba2, I have reviewed the code and it looks OK.
  8. hebasto merged this on Apr 26, 2025
  9. hebasto closed this on Apr 26, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-03 02:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me