GUI warnings should go to the log, not to the console (which may not be connected at all).
Replace stray tfm::format to cerr with qWarning #868
pull laanwj wants to merge 1 commits into bitcoin-core:master from laanwj:2025-05-qt-stray-format changing 1 files +1 −1-
laanwj commented at 10:38 AM on April 24, 2025: member
-
edd46566bd
qt: Replace stray tfm::format to cerr with qWarning
GUI warnings should go to the log, not to the console (which may not be connected at all).
- laanwj added the label Wallet on Apr 24, 2025
-
DrahtBot commented at 10:38 AM on April 24, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- hebasto renamed this:
qt: Replace stray tfm::format to cerr with qWarning
Replace stray tfm::format to cerr with qWarning
on Apr 24, 2025 - hebasto approved
-
hebasto commented at 6:02 PM on April 25, 2025: member
ACK edd46566bd66cea7d7f4116429fe1c11d2187ba2, I have reviewed the code and it looks OK.
- hebasto merged this on Apr 26, 2025
- hebasto closed this on Apr 26, 2025
- fanquake referenced this in commit 589b56192f on May 22, 2025
- stickies-v referenced this in commit 772a33e052 on May 23, 2025
- sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
- yuvicc referenced this in commit 069643f094 on Jul 6, 2025
- bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
- bitcoin-core locked this on Apr 26, 2026
