Fix compatibility with -debuglogfile command-line option #884

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:250819-debuglog changing 1 files +1 −1
  1. hebasto commented at 10:28 am on August 19, 2025: member
    This change avoids hardcoding the “debug.log” filename, ensuring compatibility with custom filenames provided via the -debuglogfile command-line option.
  2. qt: Fix compatibility with `-debuglogfile` command-line option
    This change avoids hardcoding the "debug.log" filename, ensuring
    compatibility with custom filenames provided via the `-debuglogfile`
    command-line option.
    c0d28c8f5b
  3. DrahtBot commented at 10:29 am on August 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK pablomartin4btc, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto commented at 11:00 am on August 19, 2025: member

    Incorporated into https://github.com/bitcoin/bitcoin/pull/33215.

    Closing.

  5. hebasto closed this on Aug 19, 2025

  6. hebasto commented at 11:15 am on August 19, 2025: member

    Incorporated into bitcoin/bitcoin#33215.

    That PR is not actually ready.

    Closing.

    Reopened.

  7. hebasto reopened this on Aug 19, 2025

  8. pablomartin4btc approved
  9. pablomartin4btc commented at 4:54 am on August 22, 2025: contributor

    ACK c0d28c8f5b150a03de75155a0961b3d9b2695ed6

    LogInstance().m_file_path is being set in init::SetLoggingOptions(args).

    Need to restart some CIs (few were cancelled when PR got closed)?

  10. DrahtBot closed this on Sep 3, 2025

  11. DrahtBot reopened this on Sep 3, 2025

  12. DrahtBot closed this on Sep 3, 2025

  13. DrahtBot reopened this on Sep 3, 2025

  14. DrahtBot added this to the milestone 30.0 on Sep 3, 2025
  15. maflcko commented at 12:17 pm on September 3, 2025: contributor

    tested ACK c0d28c8f5b150a03de75155a0961b3d9b2695ed6 💳

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: tested ACK c0d28c8f5b150a03de75155a0961b3d9b2695ed6 💳
    3pgEl2g3bDWKhmyEMrvuYMgUeR84rOWLCvM6W8ongbdw3TFBm0kCEdwf1QKBOCCBObtIDlZOFfPLXQXooZS5VCw==
    
  16. maflcko commented at 2:28 pm on September 3, 2025: contributor
    (ci failure can be ignored, see https://github.com/bitcoin/bitcoin/issues/33293)
  17. hebasto merged this on Sep 5, 2025
  18. hebasto closed this on Sep 5, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-16 08:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me