This change avoids hardcoding the "debug.log" filename, ensuring compatibility with custom filenames provided via the -debuglogfile command-line option.
Fix compatibility with `-debuglogfile` command-line option #884
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:250819-debuglog changing 1 files +1 −1-
hebasto commented at 10:28 AM on August 19, 2025: member
-
c0d28c8f5b
qt: Fix compatibility with `-debuglogfile` command-line option
This change avoids hardcoding the "debug.log" filename, ensuring compatibility with custom filenames provided via the `-debuglogfile` command-line option.
-
DrahtBot commented at 10:29 AM on August 19, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK pablomartin4btc, maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
hebasto commented at 11:00 AM on August 19, 2025: member
Incorporated into https://github.com/bitcoin/bitcoin/pull/33215.
Closing.
- hebasto closed this on Aug 19, 2025
-
hebasto commented at 11:15 AM on August 19, 2025: member
- hebasto reopened this on Aug 19, 2025
- pablomartin4btc approved
-
pablomartin4btc commented at 4:54 AM on August 22, 2025: contributor
ACK c0d28c8f5b150a03de75155a0961b3d9b2695ed6
LogInstance().m_file_pathis being set ininit::SetLoggingOptions(args).Need to restart some CIs (few were cancelled when PR got closed)?
- DrahtBot closed this on Sep 3, 2025
- DrahtBot reopened this on Sep 3, 2025
- DrahtBot closed this on Sep 3, 2025
- DrahtBot reopened this on Sep 3, 2025
- DrahtBot added this to the milestone 30.0 on Sep 3, 2025
-
maflcko commented at 12:17 PM on September 3, 2025: contributor
tested ACK c0d28c8f5b150a03de75155a0961b3d9b2695ed6 💳
<details><summary>Show signature</summary>
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}" RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM= trusted comment: tested ACK c0d28c8f5b150a03de75155a0961b3d9b2695ed6 💳 pgEl2g3bDWKhmyEMrvuYMgUeR84rOWLCvM6W8ongbdw3TFBm0kCEdwf1QKBOCCBObtIDlZOFfPLXQXooZS5VCw==</details>
-
maflcko commented at 2:28 PM on September 3, 2025: contributor
(ci failure can be ignored, see https://github.com/bitcoin/bitcoin/issues/33293)
- hebasto merged this on Sep 5, 2025
- hebasto closed this on Sep 5, 2025
Milestone
30.0