bugfix: Close transaction detail windows when switching wallets #941

pull pablomartin4btc wants to merge 2 commits into bitcoin-core:master from pablomartin4btc:gui/close-tx-windows-on-wallet-switch changing 4 files +43 −0

pablomartin4btc commented at 5:58 PM on June 18, 2026: contributor

<details> <summary>When the user switches to a different wallet, any open transaction detail windows (<code>TransactionDescDialog</code>) from the previous wallet's view remain visible. The dialogs are backed by the outgoing wallet's data but stay on screen, which is confusing.</summary> <img width="1017" height="646" alt="before" src="https://github.com/user-attachments/assets/6d183d77-1cee-4bf1-9271-2c2cc6b76d92" /> </details> <details> <summary>Fix by adding <code>WalletView::closeTransactionDialogs()</code> (delegating to the existing <code>TransactionView::closeOpenedDialogs()</code>) and calling it from <code>WalletFrame::setCurrentWallet()</code> when hiding the outgoing view.</summary> <img width="1017" height="646" alt="after" src="https://github.com/user-attachments/assets/2774aa08-c912-40c8-8ca6-64b8469c0364" /> </details>

A Qt test was added to verify that open transaction detail dialogs are closed when closeOpenedDialogs() is called.

Possible follow-up: remembering which transaction detail windows were open per wallet and restore them when switching back to that wallet.

qt: Close transaction detail dialogs on wallet switch

Add WalletView::closeTransactionDialogs() which delegates to
TransactionView::closeOpenedDialogs(). Call it from
WalletFrame::setCurrentWallet() when hiding the outgoing wallet view,
so any open TransactionDescDialog windows from the previous wallet are
closed before the view is hidden.

95de84bb29

qt, test: Add test for closing transaction detail dialogs on wallet switch

Add TestCloseTransactionDialogs() which selects a transaction, opens
its detail dialog via showDetails(), then calls closeOpenedDialogs()
and verifies the dialog is gone. Exercises the path triggered by
WalletView::closeTransactionDialogs() during a wallet switch.

b30b75d64e

DrahtBot commented at 5:58 PM on June 18, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
pablomartin4btc commented at 2:20 AM on June 24, 2026: contributor
-<ins>Updates</ins>:
- Added before/ after animated gifs into the PR description.

Contributors

pablomartin4btc

DrahtBot

bugfix: Close transaction detail windows when switching wallets #941

Reviews