qt: warn about rescan in wallet migration dialogs #943

pull ShauryaaSharma wants to merge 1 commits into bitcoin-core:master from ShauryaaSharma:fix-qt-migration-rescan-warning changing 1 files +10 −3

ShauryaaSharma commented at 8:14 PM on June 20, 2026: none
Problem

Fixes #930.

Migrating a legacy wallet triggers an automatic blockchain rescan immediately after the conversion completes. Depending on chain size and whether -blockfilterindex is enabled, this rescan can take anywhere from minutes to hours. During this time the progress dialog shows "Migrating Wallet…" with no indication that a rescan is happening — only the debug log reveals what is going on.

Fix

Three changes, all in MigrateWalletActivity:

1 & 2 — Confirmation dialogs (migrate() and restore_and_migrate()): append a rescan warning to the informative text so users know what to expect before clicking Confirm:

After migration, the wallet will be rescanned for transactions. Depending on the size of the blockchain and whether block filter indexes are available, this rescan may take a significant amount of time.

3 — Progress dialog (do_migrate()): update the label from the bare "Migrating Wallet…" to also mention the rescan, so users who are already in the waiting phase have context:

Migrating Wallet name…

A blockchain rescan will follow and may take a significant amount of time.

Notes
- All changes are confined to src/qt/walletcontroller.cpp.
- No behaviour or logic is changed — this is purely informational UI text.
- The rescan itself is performed inside migrateWallet() as a single blocking call; separating migration from rescan would require wallet backend changes and is out of scope here.

qt: warn about rescan in wallet migration dialogs

Migrating a legacy wallet triggers a blockchain rescan
immediately after conversion. Depending on the chain
size and whether -blockfilterindex is active, this
rescan can take anywhere from minutes to hours, with no
visual indication that anything is happening.

Add a rescan warning to the informative text of both
migration confirmation dialogs (migrate and
restore-and-migrate) so users can plan accordingly
before clicking Confirm.

Also update the progress dialog label in do_migrate()
to state that a blockchain rescan will follow migration,
giving users context while the operation runs.

Fixes #930

815d3090bf

DrahtBot commented at 8:15 PM on June 20, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
ShauryaaSharma commented at 6:04 AM on June 28, 2026: none
Hi @hebasto @fanquake , gentle ping on this one!

This is a small UX-only fix for wallet migration, no logic or behaviour changes, purely informational text updates confined to src/qt/walletcontroller.cpp.

Problem: migrating a legacy wallet silently triggers a blockchain rescan that can take minutes to hours. The progress dialog just shows "Migrating Wallet…" with no indication a rescan is coming or is in progress, users have no way to know without watching the debug log.

Three text-only changes in MigrateWalletActivity:
- migrate() confirmation dialog, appends rescan warning before the user clicks Confirm
- restore_and_migrate() confirmation dialog, same warning appended
- do_migrate() progress label, updated from bare "Migrating Wallet…" to also mention the rescan:
  
  Migrating Wallet name… A blockchain rescan will follow and may take a significant amount of time.
Out of scope (noted for clarity): separating the migration step from the rescan would require wallet backend changes, this PR intentionally doesn't touch that.

Happy to adjust the wording if it doesn't match the tone used elsewhere in the Qt dialogs.

Fixes #930.

Contributors

ShauryaaSharma

DrahtBot

Linked (view graph)

#930 Wallet migration includes rescan

qt: warn about rescan in wallet migration dialogs #943

Problem

Fix

Notes

Reviews