On macOS, test_bitcoin-qt has skipped AppTests, WalletTests, and AddressBookTests under the minimal QPA plugin since https://github.com/bitcoin/bitcoin/commit/a3197c5294df4711bab0ff6dcdd061ceab115c7d (2018, Qt 5.11), pointing to QTBUG-49686.
The recent re-evaluation of the Bitcoin Core codebase showed that the Qt bug report is no longer relevant. The remaining causes were in our own code, and they are fixed in the first commit.
`[NSApplication sharedApplication]` creates the shared application
object if it does not yet exist. When running with the `minimal` or
`offscreen` QPA plugins, which is common for testing purposes, the Cocoa
platform plugin never creates it, so these call sites were instantiating
`NSApplication` as a side effect.
Use the `NSApp` global instead and return early when it is `nil`.
The crash source, implicit `NSApplication` instantiation with a
non-Cocoa QPA plugin, was fixed in the previous commit.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, pablomartin4btc |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
lgtm ACK fd59d68c2629440e544ffa6c9a96b4252ebf45c3
tACK fd59d68c2629440e544ffa6c9a96b4252ebf45c3
I recently ran into this when writing tests for addressbooktests.cpp in #945 — they had to be run on Linux because they were skipped on macOS.
Tested locally — AppTests, WalletTests, and AddressBookTests now run with QT_QPA_PLATFORM=minimal on macOS.
From the macOS native CI logs, test_bitcoin-qt runs and passes but it's unclear whether those three test classes were previously being skipped or actually executing.
From the macOS native CI logs,
test_bitcoin-qtruns and passes but it's unclear whether those three test classes were previously being skipped or actually executing.
For the tests run by the ctest driver, you can use the --verbose option:
ctest --test-dir build_dev_mode -R bitcoin-qt --verbose
After this change the tests segfault if you build using depends: https://github.com/bitcoin/bitcoin/issues/35771.