test: recursive async IPC calls and cleanups #301

pull Eunovo wants to merge 1 commits into bitcoin-core:master from Eunovo:2026-recursive-IPC-test changing 1 files +21 −52

Eunovo commented at 6:32 AM on July 1, 2026: contributor

Test that async processing threads correctly handle incoming requests while waiting on another. Also use the opportunity to refactor some of the tests to remove the try-catch blocks. Broken out from https://github.com/bitcoin-core/libmultiprocess/pull/300

test: recursive async IPC calls

Test that async processing threads correctly handle incoming requests
while waiting on another.

Also use the opportunity to refactor some of the tests to remove
the try-catch blocks.

5519f7f948

DrahtBot commented at 6:33 AM on July 1, 2026: none


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK ryanofsky

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #300 (Server-wide ThreadPool by Eunovo)
- #288 (Create support branch for CI scripts, documentation, and examples by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Type	Reviewers
ACK	ryanofsky

in test/mp/test/test.cpp:45 in 5519f7f948

  37 | @@ -38,6 +38,15 @@
  38 |  #include <utility>
  39 |  #include <vector>
  40 |  
  41 | +//! Assert that a call throws std::runtime_error with the given message.
  42 | +#define EXPECT_EXCEPTION(call, message)                                           \
  43 | +    try {                                                                         \
  44 | +        call;                                                                     \
  45 | +        KJ_EXPECT(false);                                                         \

ryanofsky commented at 8:31 PM on July 5, 2026:

In commit "test: recursive async IPC calls" (5519f7f9485c342d7c868846985750d6f152f359)

Could be better to improve output in this case with something like KJ_FAIL_EXPECT("Expected exception was not thrown: " message)

ryanofsky approved
ryanofsky commented at 8:32 PM on July 5, 2026: collaborator

Code review ACK 5519f7f9485c342d7c868846985750d6f152f359. Thanks for the new test and test cleanup!
ryanofsky merged this on Jul 5, 2026
ryanofsky closed this on Jul 5, 2026

Contributors

Eunovo

DrahtBot

ryanofsky

Linked (view graph)

#300 Server-wide ThreadPool

test: recursive async IPC calls and cleanups #301

Reviews

Conflicts