Some follow-ups to #305#pullrequestreview-4689778284
refactor: memcpy -> std::ranges::copy #307
pull maflcko wants to merge 3 commits into bitcoin-core:master from maflcko:2607-ranges changing 4 files +12 −8-
maflcko commented at 9:11 AM on July 14, 2026: contributor
-
696c21ce5c
refactor: Directly use value in CustomBuildField
This avoids a std::span ctor. Recommended in https://github.com/bitcoin-core/libmultiprocess/pull/305#pullrequestreview-4689778284
-
26341f368c
test: Fix typo in listen_tests.cpp
Recommended by the LLM in https://github.com/bitcoin/bitcoin/pull/35684#issuecomment-4916571942
-
9ebeb9c85c
refactor: memcpy -> std::ranges::copy
I think there is no issue of passing a nullptr here, but it makes sense to use the std-lib copy for consistency. Recommended in https://github.com/bitcoin-core/libmultiprocess/pull/305#pullrequestreview-4689778284
-
DrahtBot commented at 9:11 AM on July 14, 2026: none
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 10:01 AM on July 14, 2026: contributor
ci failure looks unrelated
