cmake: Remove `QUIET` option from `find_package(CapnProto ...)` #325

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:260731-find-quiet changing 1 files +1 −1
  1. hebasto commented at 4:53 PM on July 31, 2026: member

    Cap'n Proto's Autotools-installed package config forwards the QUIET option to its internal find_package(PkgConfig) call and, when QUIET is given, suppresses its own diagnostics. As a result, a missing PkgConfig (for example, with the system capnproto package on NetBSD) was indistinguishable from capnproto itself being absent:

    $ cmake -B build
    -- The CXX compiler identification is GNU 12.5.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/c++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE
    CMake Error at CMakeLists.txt:18 (message):
      Cap'n Proto is required but was not found.
    
      To resolve, choose one of the following:
    
        - Install Cap'n Proto (version 1.0+ recommended)
        - For Bitcoin Core compilation build with -DENABLE_IPC=OFF to disable multiprocess support
    
    
    
    -- Configuring incomplete, errors occurred!
    $ sudo pkgin install capnproto
    Password:
    calculating dependencies...done.
    
    1 package to install:
      capnproto-1.4.0
    
    0 to remove, 0 to refresh, 0 to upgrade, 1 to install
    2652K to download, 21M of additional disk space will be used
    
    proceed ? [Y/n] y
    [1/1] capnproto-1.4.0.tgz                                                                                                                         100% 2652KB   2.6MB/s   00:01    
    [1/1] installing capnproto-1.4.0...
    pkg_install warnings: 0, errors: 0
    reading local summary...
    processing local summary...
    $ cmake -B build --fresh
    -- The CXX compiler identification is GNU 12.5.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/c++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE
    CMake Error at CMakeLists.txt:18 (message):
      Cap'n Proto is required but was not found.
    
      To resolve, choose one of the following:
    
        - Install Cap'n Proto (version 1.0+ recommended)
        - For Bitcoin Core compilation build with -DENABLE_IPC=OFF to disable multiprocess support
    
    
    
    -- Configuring incomplete, errors occurred!
    

    Without QUIET, the actual cause can be diagnosed:

    $ cmake -B build --fresh
    -- The CXX compiler identification is GNU 12.5.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/c++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE
    -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
    CMake Warning at /usr/pkg/lib/cmake/CapnProto/CapnProtoTargets.cmake:40 (message):
      pkg-config cannot be found
    Call Stack (most recent call first):
      /usr/pkg/lib/cmake/CapnProto/CapnProtoConfig.cmake:102 (include)
      CMakeLists.txt:16 (find_package)
    
    
    CMake Warning at CMakeLists.txt:16 (find_package):
      Found package configuration file:
    
        /usr/pkg/lib/cmake/CapnProto/CapnProtoConfig.cmake
    
      but it set CapnProto_FOUND to FALSE so package "CapnProto" is considered to
      be NOT FOUND.
    
    
    CMake Error at CMakeLists.txt:18 (message):
      Cap'n Proto is required but was not found.
    
      To resolve, choose one of the following:
    
        - Install Cap'n Proto (version 1.0+ recommended)
        - For Bitcoin Core compilation build with -DENABLE_IPC=OFF to disable multiprocess support
    
    
    
    -- Configuring incomplete, errors occurred!
    
  2. cmake: Remove `QUIET` option from `find_package(CapnProto ...)`
    Cap'n Proto's Autotools-installed package config forwards the `QUIET`
    option to its internal `find_package(PkgConfig)` call and, when `QUIET`
    is given, suppresses its own diagnostics. As a result, a missing
    `PkgConfig` (for example, with the system `capnproto` package on NetBSD)
    was indistinguishable from `capnproto` itself being absent.
    
    Without `QUIET`, the actual cause can be diagnosed:
    ```
    -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
    CMake Warning at /usr/pkg/lib/cmake/CapnProto/CapnProtoTargets.cmake:40 (message):
      pkg-config cannot be found
    Call Stack (most recent call first):
      /usr/pkg/lib/cmake/CapnProto/CapnProtoConfig.cmake:102 (include)
      CMakeLists.txt:16 (find_package)
    
    CMake Warning at CMakeLists.txt:16 (find_package):
      Found package configuration file:
    
        /usr/pkg/lib/cmake/CapnProto/CapnProtoConfig.cmake
    
      but it set CapnProto_FOUND to FALSE so package "CapnProto" is considered to
      be NOT FOUND.
    
    CMake Error at CMakeLists.txt:18 (message):
      Cap'n Proto is required but was not found.
    
      To resolve, choose one of the following:
    
        - Install Cap'n Proto (version 1.0+ recommended)
        - For Bitcoin Core compilation build with -DENABLE_IPC=OFF to disable multiprocess support
    
    -- Configuring incomplete, errors occurred!
    ```
    a494b764de
  3. DrahtBot commented at 4:53 PM on July 31, 2026: none

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. ryanofsky approved
  5. ryanofsky commented at 9:59 PM on August 3, 2026: collaborator

    Code review ACK a494b764de5fddd527e6859f915c3b80c88f4969. Makes sense, nice cleanup!

  6. ryanofsky merged this on Aug 3, 2026
  7. ryanofsky closed this on Aug 3, 2026

  8. hebasto deleted the branch on Aug 4, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-05 20:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me