refactor: drop redundant semicolons #332

pull fanquake wants to merge 2 commits into bitcoin-core:master from fanquake:drop_redundant_semi changing 4 files +71 −71

fanquake commented at 10:17 AM on August 4, 2026: member

These were already used inconsistently, i.e:

https://github.com/bitcoin-core/libmultiprocess/blob/67302cd132ade64ce28917988f2065e7d4c59437/test/mp/test/listen_tests.cpp#L223

so just nuke all the redundant ;. Some also just dropped in https://github.com/bitcoin-core/libmultiprocess/commit/bd508311b5617bd8d31b875d8781392f2a6ad7be.
test: remove redundant semicolons cbcc2ba7f9
ci: add -Wextra-semi -Wextra-semi-stmt to default config bf3dbbc063
DrahtBot commented at 10:17 AM on August 4, 2026: none


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #304 (proxy: fix BuildList to use non-const iteration for interface types by ryanofsky)
- #298 (Fix error handling when creating clients (mp::ConnectStream) by xyzconstant)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in test/mp/test/test.cpp:577 in bf3dbbc063
```
 574 |                      done.set_value();
 575 |                  }));
 576 |      });
 577 |      done.get_future().get();
 578 | -    KJ_EXPECT(error_thrown);
 579 | +    KJ_EXPECT(error_thrown)
```
maflcko commented at 10:34 AM on August 4, 2026:

hmm, for macros, I generally prefer if they enforce a trailing semicolon.

Though, it may be too late to fix this now?

hebasto commented at 10:50 AM on August 4, 2026:

Then perhaps omit -Wextra-semi-stmt?
maflcko commented at 10:35 AM on August 4, 2026: contributor

Seems fine, but I am -0
fanquake commented at 10:44 AM on August 4, 2026: member

Yea. I don't have too much of an opinion, but it wasn't clear to me why a PR labelled "CI" (#321) was also making random source code changes (bd508311b5617bd8d31b875d8781392f2a6ad7be) (although it seems like that PR was generally confusing (https://github.com/bitcoin-core/libmultiprocess/pull/321#issuecomment-5171132506)), so thought we could at least make this consistent.
maflcko commented at 10:51 AM on August 4, 2026: contributor

I think 321 was dropping it after a function def, this one is dropping it after statements.
hebasto commented at 10:51 AM on August 4, 2026: member

... random source code changes (bd50831)...

See #321 (review).
fanquake commented at 10:57 AM on August 4, 2026: member

See #321 (review).

Thanks. It would be good to write commit messages that contain information for other contributors (which then persists over time), so they don't have to search through GitHub comments to try and find context/explanations.

Contributors

refactor: drop redundant semicolons #332

Reviews

Conflicts