test: check ReadList return value #338

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/listtest changing 4 files +6 −0
  1. ryanofsky commented at 10:17 PM on August 7, 2026: collaborator

    This is a followup to #285 (review), adding a test to verify the ReadList return value and make sure it is compatible with ReadDestTemp

  2. test: check ReadList return value
    ReadList was originally declared void and did not return the result of
    read_dest.update(), silently discarding the return value. When callers
    pass a ReadDestTemp or other ReadDest whose update() returns a
    constructed value, that value was lost.
    
    Add a test to demonstrate the bug: extend FooCustom with a v3
    :List(Int32) / std::vector<int> field and use the assignment pattern
      value.v3 = ReadField(..., ReadDestTemp<std::vector<int>>())
    inside CustomReadField. This fails to compile if ReadList returns void
    and succeeds with the fix.
    
    Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
    62f25af06c
  3. DrahtBot commented at 10:17 PM on August 7, 2026: none

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK ViniciusCestarii

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. ViniciusCestarii commented at 1:04 PM on August 8, 2026: contributor

    ACK 62f25af06c39636d5e09d85753d3e958f264eec1

  5. ryanofsky merged this on Aug 11, 2026
  6. ryanofsky closed this on Aug 11, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-23 22:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me