ci: bump cmake version to 4.3.4 in newdeps job #359

pull ryanofsky wants to merge 2 commits into bitcoin-core:master from ryanofsky:pr/cmake434 changing 2 files +3 −2

ryanofsky commented at 2:27 PM on August 26, 2026: collaborator

Update cmake from 4.1.1 to 4.3.4 and add capnproto branch comment as suggested in #212 reviews

ci: bump cmake version to 4.3.4 in newdeps job

Update cmake from 4.1.1 to 4.3.4, including the corresponding sha256
hash in shell.nix.

Suggested-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Reference: https://github.com/bitcoin-core/libmultiprocess/pull/212#pullrequestreview-5002523847
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cc3675280b

ci: clarify CAPNP_CHECKOUT=master is the v1.x release branch

capnproto's default branch switched to v2, so "master" is non-obvious.

Suggested-by: MarcoFalke <falke.marco@gmail.com>
Reference: https://github.com/bitcoin-core/libmultiprocess/pull/212#discussion_r3827402335
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

766867fb32

DrahtBot commented at 2:27 PM on August 26, 2026: none



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK maflcko, hebasto

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
maflcko commented at 2:55 PM on August 26, 2026: contributor

lgtm ACK 766867fb326a8cc11aa4c0d6142288609b9bce72 code changes seem fine, but the Co-Authored-By: Claude seems a bit extraneous, when all it did was cherry-picking my diff from GitHub. No strong opinion, but my preference would be to drop the tag here.
hebasto approved
hebasto commented at 3:32 PM on August 26, 2026: member

ACK 766867fb326a8cc11aa4c0d6142288609b9bce72.
ryanofsky merged this on Sep 8, 2026
ryanofsky closed this on Sep 8, 2026

Type	Reviewers
ACK	maflcko, hebasto

Contributors

Linked (view graph)

#212 ci: add newdeps job testing newer versions of cmake and capnproto

ci: bump cmake version to 4.3.4 in newdeps job #359

Reviews