If merged, this would be used downstream in https://github.com/bitcoin/bitcoin/pull/36167.
Enable `-Wunused` #362
pull fanquake wants to merge 2 commits into bitcoin-core:master from fanquake:enable_wunused changing 20 files +46 −46-
fanquake commented at 10:40 AM on September 9, 2026: member
-
DrahtBot commented at 10:40 AM on September 9, 2026: none
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #366 (ci: Compile with minimum supported g++-10 in olddeps by maflcko)
- #342 (Allow request cancellation for wrapped C++ methods by xyzconstant)
- #175 (Set cmake_minimum_required(VERSION 3.22) by maflcko)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake force-pushed on Sep 9, 2026
- fanquake force-pushed on Sep 9, 2026
- fanquake force-pushed on Sep 9, 2026
-
refactor: remove unused code e947365e1a
- fanquake force-pushed on Sep 10, 2026
-
fanquake commented at 1:19 PM on September 10, 2026: member
Not quite sure what is happening here. The job is failing with the following (https://github.com/bitcoin-core/libmultiprocess/actions/runs/34366056349/job/102514949616?pr=362#step:6:253):
Warning: include-what-you-use reported diagnostics: error: unknown warning option '-Wtrailing-whitespace'; did you mean '-Wunicode-whitespace'? [-Werror,-Wunknown-warning-option]However
-Wtrailing-whitespacealready exists in the config on master, so I don't see why the CI would be passing on the master branch, but failing with that issue here. From what I can tell, even though GCC is the compiler being used by CMake (where this flag is supported), include-what-you-use is parsing using Clang, which doesn't support the flag. -
ci: add -Wunused to CI configs 08389342b0
- fanquake force-pushed on Sep 10, 2026
-
fanquake commented at 1:30 PM on September 10, 2026: member
Adding
-Wno-unused-command-line-argumentfixes the unknown warning option error (that makes sense as a side-effect, given the-Wunusedaddition), however the job is still failing with IWYU issues, that aren't present on master? -
maflcko commented at 10:28 AM on September 16, 2026: contributor
Looks like this also exposes a build race in https://github.com/bitcoin-core/libmultiprocess/actions/runs/34482806488/job/102889597378?pr=362#step:6:384?
- DrahtBot added the label Needs rebase on Oct 1, 2026
-
DrahtBot commented at 4:50 PM on October 1, 2026: none
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
Labels