Enable `-Wunused` #362

pull fanquake wants to merge 2 commits into bitcoin-core:master from fanquake:enable_wunused changing 20 files +46 −46
  1. fanquake commented at 10:40 AM on September 9, 2026: member

    If merged, this would be used downstream in https://github.com/bitcoin/bitcoin/pull/36167.

  2. DrahtBot commented at 10:40 AM on September 9, 2026: none

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #342 (Allow request cancellation for wrapped C++ methods by xyzconstant)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. fanquake force-pushed on Sep 9, 2026
  4. fanquake force-pushed on Sep 9, 2026
  5. fanquake force-pushed on Sep 9, 2026
  6. refactor: remove unused code e947365e1a
  7. fanquake force-pushed on Sep 10, 2026
  8. fanquake commented at 1:19 PM on September 10, 2026: member

    Not quite sure what is happening here. The job is failing with the following (https://github.com/bitcoin-core/libmultiprocess/actions/runs/34366056349/job/102514949616?pr=362#step:6:253):

    Warning: include-what-you-use reported diagnostics:
    error: unknown warning option '-Wtrailing-whitespace'; did you mean '-Wunicode-whitespace'? [-Werror,-Wunknown-warning-option]
    

    However -Wtrailing-whitespace already exists in the config on master, so I don't see why the CI would be passing on the master branch, but failing with that issue here. From what I can tell, even though GCC is the compiler being used by CMake (where this flag is supported), include-what-you-use is parsing using Clang, which doesn't support the flag.

  9. ci: add -Wunused to CI configs 08389342b0
  10. fanquake force-pushed on Sep 10, 2026
  11. fanquake commented at 1:30 PM on September 10, 2026: member

    Adding -Wno-unused-command-line-argument fixes the unknown warning option error (that makes sense as a side-effect, given the -Wunused addition), however the job is still failing with IWYU issues, that aren't present on master?

Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-16 09:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me