ci: use newer `actions/*` versions #387

pull fanquake wants to merge 2 commits into bitcoin-core:master from fanquake:github_slop changing 3 files +17 −17
  1. fanquake commented at 2:13 PM on November 3, 2026: member

    See warnings in CI runs. i.e https://github.com/bitcoin-core/libmultiprocess/actions/runs/41650738892/job/125967883187?pr=386:

    Complete job Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache/restore@v4, actions/cache/save@v4, actions/cache@v4, actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

  2. DrahtBot commented at 2:13 PM on November 3, 2026: none

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. fanquake force-pushed on Nov 3, 2026
  4. fanquake force-pushed on Nov 3, 2026
  5. ci: use newer actions/ versions 0bce5ed7a4
  6. fanquake force-pushed on Nov 3, 2026
  7. maflcko commented at 2:43 PM on November 3, 2026: contributor

    The prior curl error was a bit cryptic. Could make it verbose via:

    diff --git a/ci/scripts/bitcoin_core_ci.sh b/ci/scripts/bitcoin_core_ci.sh
    index 7f3c5cb..2f64a09 100755
    --- a/ci/scripts/bitcoin_core_ci.sh
    +++ b/ci/scripts/bitcoin_core_ci.sh
    @@ -15,7 +15,7 @@ replace_subtree() {
     }
     
     add_llvm_apt_repository() {
    -  curl -s "https://apt.llvm.org/llvm-snapshot.gpg.key" | sudo tee "/etc/apt/trusted.gpg.d/apt.llvm.org.asc" > /dev/null
    +  curl --fail --silent --show-error --location "https://apt.llvm.org/llvm-snapshot.gpg.key" | sudo tee "/etc/apt/trusted.gpg.d/apt.llvm.org.asc" > /dev/null
       source /etc/os-release
       echo "deb http://apt.llvm.org/${VERSION_CODENAME}/ llvm-toolchain-${VERSION_CODENAME}-${LLVM_VERSION} main" | sudo tee "/etc/apt/sources.list.d/llvm.list"
       sudo apt-get update
    
  8. ci: make curl fail more loudly cf2164ba0e
  9. maflcko commented at 2:57 PM on November 3, 2026: contributor

    Nice, now the error is: curl: (6) Could not resolve host: apt.llvm.org.

    I guess it can be ignored.

  10. fanquake renamed this:
    ci: use actions/checkout@v7
    ci: use newer `actions/*` versions
    on Nov 3, 2026
  11. in .github/workflows/bitcoin-core-ci.yml:79 in cf2164ba0e
      75 | @@ -76,14 +76,14 @@ jobs:
      76 |  
      77 |      steps:
      78 |        - name: Checkout Bitcoin Core
      79 | -        uses: actions/checkout@v4
      80 | +        uses: actions/checkout@v7
    


    ryanofsky commented at 4:37 PM on November 3, 2026:

    In commit "ci: use newer actions/ versions" (0bce5ed7a415ef17d67c7b9972eb926bf148b482)

    Note for reviewers: the only behavior change in checkout v7 is refusing to check out fork PRs in pull_request_target and workflow_run workflows (https://github.com/actions/checkout/pull/2454). Both workflows here run on push and pull_request only, so it doesn't affect them. cache v6 is a dependency and ESM update with no input changes. The new run's job annotations have no Node 20 warnings left.

  12. ryanofsky approved
  13. ryanofsky commented at 4:38 PM on November 3, 2026: collaborator

    Code review ACK cf2164ba0e2ee331147b633cf549c440192d2ac9. Thanks for cleaning up the deprecation warnings and making the curl failure readable.

    The ASan and TSan failures are the apt.llvm.org DNS outage, not this PR.

  14. ryanofsky merged this on Nov 3, 2026
  15. ryanofsky closed this on Nov 3, 2026

  16. fanquake deleted the branch on Nov 3, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-17 18:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me