ci: Add OpenIndiana job #393

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:261106-ci-illumos changing 3 files +37 −2
  1. hebasto commented at 3:44 PM on November 6, 2026: member

    The new CI job covers code paths for illumos-based systems.

    Draft for now, as two tests that currently fail on illumos need fixing first:

    • the "has OS thread name" tests, addressed in #392, which this PR is based on;
    • the "disconnects before being accepted" test, which is a reincarnation of #319.
  2. DrahtBot commented at 3:44 PM on November 6, 2026: none

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #373 (ci: Add CAPNP_BUILD=autotools-static and enable in newdeps by mutatrum)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. xyzconstant commented at 10:14 PM on November 6, 2026: contributor

    Regarding the failing test (setsocketopt failure), you might want to skip the accept_error_seen assertion as we're currently doing for macOS

    diff --git a/test/mp/test/listen_tests.cpp b/test/mp/test/listen_tests.cpp
    index 41fb05a..d8d4984 100644
    --- a/test/mp/test/listen_tests.cpp
    +++ b/test/mp/test/listen_tests.cpp
    @@ -253,8 +253,8 @@ KJ_TEST("ListenConnections handles a client that disconnects before being accept
             std::this_thread::sleep_for(std::chrono::milliseconds(1));
         }
     
    -#ifndef __APPLE__
    -    // No error is expected on platforms other than macOS.
    +#if !defined(__APPLE__) && !defined(__sun)
    +    // No error is expected on platforms other than macOS and illumos.
         KJ_REQUIRE(!accept_error_seen());
     #endif
         KJ_EXPECT(server.DisconnectedCount() == (accept_error_seen() ? 0 : 1));
    
    
  4. hebasto commented at 10:21 PM on November 6, 2026: member

    Regarding the failing test (setsocketopt failure), you might want to skip the accept_error_seen assertion as we're currently doing for macOS

    diff --git a/test/mp/test/listen_tests.cpp b/test/mp/test/listen_tests.cpp
    index 41fb05a..d8d4984 100644
    --- a/test/mp/test/listen_tests.cpp
    +++ b/test/mp/test/listen_tests.cpp
    @@ -253,8 +253,8 @@ KJ_TEST("ListenConnections handles a client that disconnects before being accept
             std::this_thread::sleep_for(std::chrono::milliseconds(1));
         }
     
    -#ifndef __APPLE__
    -    // No error is expected on platforms other than macOS.
    +#if !defined(__APPLE__) && !defined(__sun)
    +    // No error is expected on platforms other than macOS and illumos.
         KJ_REQUIRE(!accept_error_seen());
     #endif
         KJ_EXPECT(server.DisconnectedCount() == (accept_error_seen() ? 0 : 1));
    

    Yeah. I've already applied the patch in https://github.com/hebasto/bitcoin-core-nightly.

  5. xyzconstant commented at 10:29 PM on November 6, 2026: contributor

    Yeah. I've already applied the patch in https://github.com/hebasto/bitcoin-core-nightly.

    Yeah, I noticed it, but that patch is for Cap'n Proto. What I suggested is a diff for test code in this repo, as is done for the macOS job.

  6. hebasto force-pushed on Nov 16, 2026
  7. hebasto commented at 7:50 PM on November 16, 2026: member

    Rebased on #396 as requested by @ryanofsky here.

  8. ryanofsky referenced this in commit d278634f8c on Nov 16, 2026
  9. ci: Add OpenIndiana job
    This covers code paths for illumos-based systems.
    3f424dfcec
  10. hebasto force-pushed on Nov 16, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-17 18:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me