The new CI job covers code paths for illumos-based systems.
Draft for now, as two tests that currently fail on illumos need fixing first:
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Regarding the failing test (setsocketopt failure), you might want to skip the accept_error_seen assertion as we're currently doing for macOS
diff --git a/test/mp/test/listen_tests.cpp b/test/mp/test/listen_tests.cpp
index 41fb05a..d8d4984 100644
--- a/test/mp/test/listen_tests.cpp
+++ b/test/mp/test/listen_tests.cpp
@@ -253,8 +253,8 @@ KJ_TEST("ListenConnections handles a client that disconnects before being accept
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
-#ifndef __APPLE__
- // No error is expected on platforms other than macOS.
+#if !defined(__APPLE__) && !defined(__sun)
+ // No error is expected on platforms other than macOS and illumos.
KJ_REQUIRE(!accept_error_seen());
#endif
KJ_EXPECT(server.DisconnectedCount() == (accept_error_seen() ? 0 : 1));
Regarding the failing test (
setsocketoptfailure), you might want to skip theaccept_error_seenassertion as we're currently doing for macOSdiff --git a/test/mp/test/listen_tests.cpp b/test/mp/test/listen_tests.cpp index 41fb05a..d8d4984 100644 --- a/test/mp/test/listen_tests.cpp +++ b/test/mp/test/listen_tests.cpp @@ -253,8 +253,8 @@ KJ_TEST("ListenConnections handles a client that disconnects before being accept std::this_thread::sleep_for(std::chrono::milliseconds(1)); } -#ifndef __APPLE__ - // No error is expected on platforms other than macOS. +#if !defined(__APPLE__) && !defined(__sun) + // No error is expected on platforms other than macOS and illumos. KJ_REQUIRE(!accept_error_seen()); #endif KJ_EXPECT(server.DisconnectedCount() == (accept_error_seen() ? 0 : 1));
Yeah. I've already applied the patch in https://github.com/hebasto/bitcoin-core-nightly.
Yeah. I've already applied the patch in https://github.com/hebasto/bitcoin-core-nightly.
Yeah, I noticed it, but that patch is for Cap'n Proto. What I suggested is a diff for test code in this repo, as is done for the macOS job.
Rebased on #396 as requested by @ryanofsky here.
This covers code paths for illumos-based systems.